fix: azure disk detach failure if node not exists #82640
Merged
+13
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
fix comments
andyzhangx
force-pushed
the
detach-azuredisk-not-found
branch
from
02bb4ba to
d11cac9
Compare
k8s-ci-robot
added
the
approved
Member
|
/retest |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Sep 15, 2019
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 20, 2019
…2640-upstream-release-1.13 Automated cherry pick of #82640: fix: azure disk detach failure if node not exists
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 20, 2019
…2640-upstream-release-1.14 Automated cherry pick of #82640: fix: azure disk detach failure if node not exists
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 20, 2019
…2640-upstream-release-1.16 Automated cherry pick of #82640: fix: azure disk detach failure if node not exists
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 20, 2019
…2640-upstream-release-1.15 Automated cherry pick of #82640: fix: azure disk detach failure if node not exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: azure disk detach failure if node not exists
Which issue(s) this PR fixes:
Fixes #82617
Special notes for your reviewer:
If a node with a Azure Disk attached is deleted (before the volume is detached), subsequent attempts by the attach/detach controller to detach it continuously fail, and prevent the controller from attaching the volume to another node.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/kind bug
/assign @feiskyer
/priority important-soon
/sig cloud-provider
/area provider/azure