Skip to content

Conversation

@andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 21, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
disk name matching should be case insensitive, proceeding fix with #81266

Which issue(s) this PR fixes:

Fixes #81079

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix azure disk naming matching issue due to case sensitive comparison

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

none

/kind bug
/assign @feiskyer
/priority important-soon
/sig cloud-provider
/area provider/azure

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider area/cloudprovider labels Aug 21, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2019
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-bazel-test

@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 34450e9 into kubernetes:master Aug 23, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 23, 2019
@feiskyer
Copy link
Member

@andyzhangx do we need cherrypicking this to old releases?

@andyzhangx
Copy link
Member Author

@andyzhangx do we need cherrypicking this to old releases?

I think so, let me do it soon.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 23, 2019
k8s-ci-robot added a commit that referenced this pull request Aug 30, 2019
…1720-upstream-release-1.13

Automated cherry pick of #81720: fix: azure disk name matching issue
k8s-ci-robot added a commit that referenced this pull request Aug 30, 2019
…1720-upstream-release-1.15

Automated cherry pick of #81720: fix: azure disk name matching issue
k8s-ci-robot added a commit that referenced this pull request Aug 30, 2019
…1720-upstream-release-1.14

Automated cherry pick of #81720: fix: azure disk name matching issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disks are not detached on Azure

4 participants