Skip to content

Upgrade to go 1.11.13 #81542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 3 commits into from
Aug 17, 2019
Merged

Upgrade to go 1.11.13 #81542

k8s-ci-robot merged 3 commits into from
Aug 17, 2019

Conversation

@BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Aug 17, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update to use go 1.11.13

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Aug 17, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 17, 2019
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 17, 2019
@BenTheElder
Copy link
Member Author

BenTheElder commented Aug 17, 2019

/cc @cblecker
I'm working on the kube-cross image now.
/sig release
since this patches CVEs:
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot requested a review from cblecker August 17, 2019 04:03
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 17, 2019
@BenTheElder
Copy link
Member Author

BenTheElder commented Aug 17, 2019

(those jobs failed due to the kube-cross image not being up yet, it's rolling out currently)

@BenTheElder
Copy link
Member Author

BenTheElder commented Aug 17, 2019

looks like bazel worked fine but failed on that malformed port in the vsphere/vclib test fixed in f713ec8

@cblecker @BenTheElder
Fix malformed port in vsphere cloud provider test
3acd9de 
The port name previously didn't matter on these tests, but is now
actively being checked in go1.12.8 and higher.

golang/go@3226f2d
@k8s-ci-robot k8s-ci-robot added the sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. label Aug 17, 2019
@BenTheElder
Copy link
Member Author

BenTheElder commented Aug 17, 2019

picked in f713ec8, k8s.gcr.io/kube-cross:v1.11.13-1 is now live so hopefully tests should pass this time ...

@BenTheElder BenTheElder mentioned this pull request Aug 17, 2019
Closed
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Aug 17, 2019
@cblecker cblecker mentioned this pull request Aug 17, 2019
Closed
@BenTheElder
Copy link
Member Author

BenTheElder commented Aug 17, 2019

/assign @cblecker @liggitt @dims

@cblecker
Copy link
Member

cblecker commented Aug 17, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2019
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 17, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 17, 2019
@liggitt
Copy link
Member

liggitt commented Aug 17, 2019

/lgtm
/approve

dougm
dougm reviewed Aug 17, 2019
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, dougm, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 52d3945 into kubernetes:release-1.13 Aug 17, 2019
@BenTheElder BenTheElder deleted the go1113 branch August 17, 2019 18:29
@liggitt liggitt removed the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkumatag mkumatag Awaiting requested review from mkumatag

@spiffxp spiffxp Awaiting requested review from spiffxp

@cblecker cblecker Awaiting requested review from cblecker

1 more reviewer

@dougm dougm dougm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dims dims

@dougm dougm

@liggitt liggitt

@cblecker cblecker

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.13

Development

Successfully merging this pull request may close these issues.

7 participants

@BenTheElder @cblecker @liggitt @k8s-ci-robot @dougm @dims @tpepper