-
Notifications
You must be signed in to change notification settings - Fork 42.1k
Fix Azure client requests stuck issues on http.StatusTooManyRequests #81279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Azure client requests stuck issues on http.StatusTooManyRequests #81279
Conversation
|
/sig cloud-provider |
|
/priority critical-urgent |
andyzhangx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the PR title could be Stop retry when got StatusTooManyRequests error ?
andyzhangx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also this PR contains two fixes, would you split? and do you want to cherry pick?
staging/src/k8s.io/legacy-cloud-providers/azure/azure_backoff.go
Outdated
Show resolved
Hide resolved
Yep, it would be cherry-picked to old versions. Let me split the PR into two, cause they would be cherry picked to different versions. |
3d2b157 to
0bcee75
Compare
0bcee75 to
e53c57a
Compare
|
/test pull-kubernetes-e2e-aks-engine-azure |
andyzhangx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Review the full test history for this PR. Silence the bot with an |
…79-upstream-release-1.14 Automated cherry pick of #81279: Fix Azure client requests stuck issues on
…79-upstream-release-1.13 Automated cherry pick of #81279: Fix Azure client requests stuck issues on
…79-upstream-release-1.15 Automated cherry pick of #81279: Fix Azure client requests stuck issues on
What type of PR is this?
/kind bug
What this PR does / why we need it:
Refer Azure/go-autorest#398. In go-autorest SDK https://github.com/Azure/go-autorest/blob/master/autorest/sender.go#L258,
if ARM returns
http.StatusTooManyRequests, the sender doesn't increase the retry attempt count,hence the Azure clients will keep retrying forever until it gets a status code other than 429.
So this PR explicitly remove
http.StatusTooManyRequestsfromautorest.StatusCodesForRetry.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/kind bug
/area provider/azure
/priority critial-urgent