Skip to content

remove iSCSI volume storage cleartext secrets in logs #81215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Aug 14, 2019
Merged

remove iSCSI volume storage cleartext secrets in logs #81215

k8s-ci-robot merged 1 commit into from
Aug 14, 2019

Conversation

@zouyee
Copy link
Member

@zouyee zouyee commented Aug 9, 2019

What type of PR is this?
/kind bug
/kind flake

What this PR does / why we need it:
remove iSCSI volume storage cleartext secrets in logs

Which issue(s) this PR fixes:

Fixes #81130

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

remove iSCSI volume storage cleartext secrets in logs

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 9, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 9, 2019
@zouyee
Copy link
Member Author

zouyee commented Aug 9, 2019

/cc @cji

@k8s-ci-robot k8s-ci-robot requested a review from cji August 9, 2019 07:46
@zouyee
Copy link
Member Author

zouyee commented Aug 10, 2019

/retest

@zouyee
Copy link
Member Author

zouyee commented Aug 11, 2019

/test pull-kubernetes-integration

@zouyee
Copy link
Member Author

zouyee commented Aug 13, 2019

/kind bug
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 13, 2019
@jsafrane
Copy link
Member

jsafrane commented Aug 14, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, zouyee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit d23b2c7 into kubernetes:master Aug 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 14, 2019
@justincormack
Copy link
Contributor

justincormack commented Aug 14, 2019

This is a security issue so should be backported.

@zouyee zouyee mentioned this pull request Aug 15, 2019
Merged
This was referenced Aug 15, 2019
Merged
Merged
@cji cji mentioned this pull request Aug 15, 2019
Open
k8s-ci-robot added a commit that referenced this pull request Aug 20, 2019
@k8s-ci-robot
Merge pull request #81441 from zouyee/automated-cherry-pick-of-#81215…
e19af8f 
…-upstream-release-1.15

Automated cherry pick of #81215: remove iSCSI volume storage cleartext secrets in logs
k8s-ci-robot added a commit that referenced this pull request Aug 20, 2019
@k8s-ci-robot
Merge pull request #81439 from zouyee/automated-cherry-pick-of-#81215…
96c8c49 
…-upstream-release-1.13

Automated cherry pick of #81215: remove iSCSI volume storage cleartext secrets in logs
k8s-ci-robot added a commit that referenced this pull request Aug 20, 2019
@k8s-ci-robot
Merge pull request #81440 from zouyee/automated-cherry-pick-of-#81215…
459ef76 
…-upstream-release-1.14

Automated cherry pick of #81215: remove iSCSI volume storage cleartext secrets in logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@cji cji Awaiting requested review from cji

Assignees

@jsafrane jsafrane

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.16

Development

Successfully merging this pull request may close these issues.

ATR-K8S-003: iSCSI volume storage cleartext secrets in logs

4 participants

@zouyee @jsafrane @k8s-ci-robot @justincormack