Default resourceGroup should be used when value of annotation azure-load-balancer-resource-group is empty string #79514
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oad-balancer-resource-group is empty string
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Member
Author
|
/assign @andyzhangx |
k8s-ci-robot
added
the
lgtm
This was referenced Jun 28, 2019
Member
Author
|
/retest |
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 29, 2019
…14-upstream-release-1.13 Automated cherry pick of #79514: Default resourceGroup should be used when value of annotation
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 29, 2019
…14-upstream-release-1.14 Automated cherry pick of #79514: Default resourceGroup should be used when value of annotation
feiskyer
added a commit
that referenced
this pull request
Jun 30, 2019
…14-upstream-release-1.12 Automated cherry pick of #79514: Default resourceGroup should be used when value of annotation
hoegaarden
added
the
cherry-pick-approved
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 3, 2019
…14-upstream-release-1.15 Automated cherry pick of #79514: Default resourceGroup should be used when value of annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it: Default resourceGroup should be used when value of annotation azure-load-balancer-resource-group is empty string.
Which issue(s) this PR fixes:
Fixes #79513
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/sig azure
/kind bug
/priority critical-urgent