Skip to content

Printer: fix a nil pointer dereference #79349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jun 25, 2019
Merged

Printer: fix a nil pointer dereference #79349

k8s-ci-robot merged 1 commit into from
Jun 25, 2019

Conversation

@roycaihw
Copy link
Member

@roycaihw roycaihw commented Jun 24, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix a nil pointer dereference that could cause kube-apiserver to panic.

Does this PR introduce a user-facing change?:

Fix a bug in server printer that could cause kube-apiserver to panic.

/sig cli

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 24, 2019
@roycaihw
Copy link
Member Author

roycaihw commented Jun 24, 2019

/cc @smarterclayton

@janetkuo janetkuo added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/apiserver and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 24, 2019
@janetkuo
Copy link
Member

janetkuo commented Jun 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2019
@janetkuo
Copy link
Member

janetkuo commented Jun 24, 2019

This needs to be cherrypicked.

@roycaihw
Copy link
Member Author

roycaihw commented Jun 24, 2019

This needs to be cherrypicked.

Sounds good. This was from 17740a2#diff-749b0f5911ddd5261b4ed5c2945d7c16R1585, which was added in 1.12. I assume 1.12 has retired so let's cherrypick it to 1.13, 1.14 and 1.15?

@roycaihw
Copy link
Member Author

roycaihw commented Jun 24, 2019

/retest

@janetkuo
Copy link
Member

janetkuo commented Jun 24, 2019

let's cherrypick it to 1.13, 1.14 and 1.15

SGTM

@roycaihw
Copy link
Member Author

roycaihw commented Jun 24, 2019

I assume 1.12 has retired so let's cherrypick it to 1.13, 1.14 and 1.15?

Actually v1.12.10 cut (the last patch release) is planned Monday, July 1st. I can prepare a cherrypick for 1.12 as well

@janetkuo Could you add the approval label? Thanks

@fejta-bot
Copy link

fejta-bot commented Jun 25, 2019

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2019
@smarterclayton
Copy link
Contributor

smarterclayton commented Jun 25, 2019

/approve
/lgtm

as well

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2019
@roycaihw
Copy link
Member Author

roycaihw commented Jun 25, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit c1fc717 into kubernetes:master Jun 25, 2019
This was referenced Jun 25, 2019
Closed
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Aug 20, 2019
@k8s-ci-robot
Merge pull request #79381 from roycaihw/automated-cherry-pick-of-#793…
e9217bf 
…49-upstream-release-1.13

Automated cherry pick of #79349: printer: fix a nil pointer dereference
k8s-ci-robot added a commit that referenced this pull request Aug 20, 2019
@k8s-ci-robot
Merge pull request #79383 from roycaihw/automated-cherry-pick-of-#793…
3742c7b 
…49-upstream-release-1.15

Automated cherry pick of #79349: printer: fix a nil pointer dereference
k8s-ci-robot added a commit that referenced this pull request Aug 20, 2019
@k8s-ci-robot
Merge pull request #79382 from roycaihw/automated-cherry-pick-of-#793…
1fc9085 
…49-upstream-release-1.14

Automated cherry pick of #79349: printer: fix a nil pointer dereference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

@soltysh soltysh Awaiting requested review from soltysh

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@janetkuo janetkuo janetkuo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@smarterclayton smarterclayton

@janetkuo janetkuo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@roycaihw @janetkuo @fejta-bot @smarterclayton @k8s-ci-robot