Skip to content

fix CVE-2019-11244: kubectl --http-cache=<world-accessible dir> cre… #77874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
May 16, 2019
Merged

fix CVE-2019-11244: kubectl --http-cache=<world-accessible dir> cre… #77874

k8s-ci-robot merged 1 commit into from
May 16, 2019
+84 −2

Conversation

@yuchengwu
Copy link
Contributor

@yuchengwu yuchengwu commented May 14, 2019 •
edited by liggitt
Loading

…ates world-writeable cached schema files

What type of PR is this?

/kind bug

What this PR does / why we need it:

In kubectl v1.8.0+, schema info is cached in the location specified by --cache-dir (defaulting to $HOME/.kube/http-cache), written with world-writeable permissions (rw-rw-rw-).

If --cache-dir is specified and pointed at a different location accessible to other users/groups, the written files may be modified by other users/groups and disrupt the kubectl invocation.

CVSS score: CVSS:3.0/AV:L/AC:H/PR:L/UI:R/S:U/C:L/I:L/A:N (3.3, low)

Which issue(s) this PR fixes:

Fixes #76676

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

client-go and kubectl no longer write cached discovery files with world-accessible file permissions

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 14, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 14, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 14, 2019

Hi @yuchengwu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 14, 2019
@k8s-ci-robot k8s-ci-robot requested review from sttts and yliaog May 14, 2019 17:37
@yuchengwu
fix CVE-2019-11244: kubectl --http-cache=<world-accessible dir> cre…
f228ae3 
…ates world-writeable cached schema files
@yuchengwu yuchengwu force-pushed the fix-CVE-2019-11244 branch from bcc913e to f228ae3 Compare May 14, 2019 17:40
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 14, 2019
@yuchengwu
Copy link
Contributor Author

yuchengwu commented May 14, 2019

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 14, 2019

@yuchengwu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuchengwu
Copy link
Contributor Author

yuchengwu commented May 14, 2019

/assign @liggitt

@BenTheElder
Copy link
Member

BenTheElder commented May 14, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2019
@neolit123
Copy link
Member

neolit123 commented May 14, 2019

/kind bug
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 14, 2019
@liggitt
Copy link
Member

liggitt commented May 15, 2019

/test pull-kubernetes-bazel-build
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, yuchengwu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 15, 2019
@neolit123
Copy link
Member

neolit123 commented May 15, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 730bc96 into kubernetes:master May 16, 2019
@yuchengwu yuchengwu deleted the fix-CVE-2019-11244 branch May 17, 2019 03:45
This was referenced May 17, 2019
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request May 17, 2019
@k8s-ci-robot
Merge pull request #78032 from yuchengwu/automated-cherry-pick-of-#77…
f6cee7a 
…874-github-release-1.12

Automated cherry pick of #77874: fix CVE-2019-11244: `kubectl --http-cache=<world-accessible
k8s-ci-robot added a commit that referenced this pull request May 21, 2019
@k8s-ci-robot
Merge pull request #78027 from yuchengwu/automated-cherry-pick-of-#77…
4ccdc8b 
…874-github-release-1.14

Automated cherry pick of #77874: fix CVE-2019-11244: `kubectl --http-cache=<world-accessible
k8s-ci-robot added a commit that referenced this pull request May 21, 2019
@k8s-ci-robot
Merge pull request #78028 from yuchengwu/automated-cherry-pick-of-#77…
211b1ad 
…874-github-release-1.13

Automated cherry pick of #77874: fix CVE-2019-11244: `kubectl --http-cache=<world-accessible
nikhita pushed a commit to nikhita/kubernetes that referenced this pull request Jun 13, 2019
@k8s-ci-robot
Merge pull request kubernetes#77874 from yuchengwu/fix-CVE-2019-11244
e1db94c 
fix CVE-2019-11244: `kubectl --http-cache=<world-accessible dir>` cre…

Kubernetes-commit: 730bc96
@RainbowMango RainbowMango mentioned this pull request Jul 25, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sttts sttts Awaiting requested review from sttts

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@liggitt liggitt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CVE-2019-11244: kubectl --http-cache=<world-accessible dir> creates world-writeable cached schema files

5 participants

@yuchengwu @k8s-ci-robot @BenTheElder @neolit123 @liggitt