Skip to content

[1.13] Bump addon-manager to v8.9.1 #77623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jun 10, 2019
Merged

[1.13] Bump addon-manager to v8.9.1 #77623

k8s-ci-robot merged 1 commit into from
Jun 10, 2019
+2 −2

Conversation

@MrHohn
Copy link
Member

@MrHohn MrHohn commented May 9, 2019 •
edited
Loading

Bumping addon-manager version in manifests to pick up the latest base image debian-base:v1.0.0.

Ref #76405.

Bump addon-manager to v8.9.1
- Rebase image on debian-base:v1.0.0

@MrHohn
Bump addon-manager to v8.9.1
0e47b0a 
- Rebase image on debian-base:v1.0.0
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 9, 2019
@k8s-ci-robot k8s-ci-robot requested review from jingax10 and shyamjvs May 9, 2019 01:17
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 9, 2019
@MrHohn
Copy link
Member Author

MrHohn commented May 9, 2019

/kind bug
/priority important-soon
/assign @tallclair

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 9, 2019
@tallclair
Copy link
Member

tallclair commented May 9, 2019

There's some inconsistency here - the linked PR is bumping to v9.0.1 but this is bumping to v8.9.1.

Is that intentional? Either way, please update the PR description to be accurate.

@MrHohn MrHohn changed the title Manual cherry pick of #77282: Bump addon-manager to v8.9.1 Bump addon-manager to v8.9.1 May 9, 2019
@MrHohn
Copy link
Member Author

MrHohn commented May 9, 2019

Right, that is intentional. Updated title and description. PTAL thanks!

@MrHohn MrHohn changed the title Bump addon-manager to v8.9.1 [1.13] Bump addon-manager to v8.9.1 May 9, 2019
@tallclair
Copy link
Member

tallclair commented May 14, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2019
@MrHohn
Copy link
Member Author

MrHohn commented May 14, 2019

Thanks Tim!
/assign @tpepper
for cherrypick approval.

@MrHohn
Copy link
Member Author

MrHohn commented May 21, 2019

Wanted to see if anyone can help approve this. Thanks!
/assign @bowei @MaciekPytel

@MaciekPytel
Copy link
Contributor

MaciekPytel commented Jun 5, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaciekPytel, MrHohn, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2019
@MaciekPytel
Copy link
Contributor

MaciekPytel commented Jun 5, 2019

@aleksandra-malinowska Can you cherry-pick approve?

@aleksandra-malinowska
Copy link
Contributor

aleksandra-malinowska commented Jun 5, 2019

Deadline for cherry-picks to 1.13.7 was Monday, June 3rd. Approving the cherry-pick now would delay this release, since there wouldn't be enough time for all the tests to run. Unless it's super urgent, let's merge it later this week.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2019
@MrHohn
Copy link
Member Author

MrHohn commented Jun 5, 2019

SGTM, @MaciekPytel @aleksandra-malinowska thanks!

@aleksandra-malinowska aleksandra-malinowska added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6e79b18 into kubernetes:release-1.13 Jun 10, 2019
mboersma added a commit to mboersma/aks-engine that referenced this pull request Jul 9, 2019
@mboersma
chore: update addon-manager to v8.9.1
78f3c67 
See kubernetes/kubernetes#77623
@mboersma mboersma mentioned this pull request Jul 9, 2019
Merged
5 tasks
acs-bot pushed a commit to Azure/aks-engine that referenced this pull request Jul 9, 2019
@mboersma @acs-bot
feat: add support for Kubernetes 1.13.8 (#1595)
64dccb5 
* feat: add support for Kubernetes 1.13.8

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.13.md#changelog-since-v1137

* chore: update addon-manager to v8.9.1

See kubernetes/kubernetes#77623

* chore: update ip-masq-agent version to v2.3.0

See kubernetes/kubernetes#77834

* chore: re-enable k8s 1.13.5 for Azure Stack support
mboersma added a commit to mboersma/aks-engine that referenced this pull request Jul 24, 2019
@mboersma
feat: add support for Kubernetes 1.13.8 (Azure#1595)
24d03dc 
* feat: add support for Kubernetes 1.13.8

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.13.md#changelog-since-v1137

* chore: update addon-manager to v8.9.1

See kubernetes/kubernetes#77623

* chore: update ip-masq-agent version to v2.3.0

See kubernetes/kubernetes#77834

* chore: re-enable k8s 1.13.5 for Azure Stack support
@jackfrancis jackfrancis mentioned this pull request Aug 8, 2019
Merged
4 tasks
mboersma added a commit to mboersma/aks-engine that referenced this pull request Aug 8, 2019
@mboersma
chore: bump <= 1.13 addon-manager to v8.9.1
430c79a 
See kubernetes/kubernetes#77623
jackfrancis pushed a commit to Azure/aks-engine that referenced this pull request Aug 8, 2019
@mboersma @jackfrancis
chore: update kube-addon-manager to v9.0.2 and v8.9.1 (#1746)
616545a 
* chore: update addon-manager to v9.0.2

See https://github.com/kubernetes/kubernetes#80575

* chore: bump <= 1.13 addon-manager to v8.9.1

See kubernetes/kubernetes#77623
CecileRobertMichon pushed a commit to Azure/aks-engine that referenced this pull request Aug 9, 2019
@mboersma
chore: update kube-addon-manager to v9.0.2 and v8.9.1 (#1746)
421f97b 
* chore: update addon-manager to v9.0.2

See https://github.com/kubernetes/kubernetes#80575

* chore: bump <= 1.13 addon-manager to v8.9.1

See kubernetes/kubernetes#77623
CecileRobertMichon pushed a commit to Azure/aks-engine that referenced this pull request Aug 9, 2019
@mboersma
chore: update kube-addon-manager to v9.0.2 and v8.9.1 (#1746)
9390d49 
* chore: update addon-manager to v9.0.2

See https://github.com/kubernetes/kubernetes#80575

* chore: bump <= 1.13 addon-manager to v8.9.1

See kubernetes/kubernetes#77623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jingax10 jingax10 Awaiting requested review from jingax10

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

Assignees

@bowei bowei

@tpepper tpepper

@MaciekPytel MaciekPytel

@tallclair tallclair

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@MrHohn @tallclair @MaciekPytel @k8s-ci-robot @aleksandra-malinowska @bowei @tpepper