Skip to content

specify azure file share name in azure file plugin #76988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2019
Merged

specify azure file share name in azure file plugin #76988

merged 1 commit into from
Apr 24, 2019

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Apr 24, 2019 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR let user

  • could specify azure file share name in azure file plugin
  • use existing azure file share in azure file plugin
---
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: azurefile
provisioner: kubernetes.io/azure-file
parameters:
  skuName: Standard_LRS
  resourceGroup: EXISTING_RESOURCE_GROUP_NAME
  storageAccount: EXISTING_STORAGE_ACCOUNT_NAME
  shareName: SHARE_NAME

Which issue(s) this PR fixes:

Fixes #76986

Special notes for your reviewer:
add shareName param in azure file storage class

Release note:

specify azure file share name in azure file plugin

/kind bug
/assign @feiskyer
/priority important-soon
/sig azure

/test pull-kubernetes-e2e-aks-engine-azure

@andyzhangx
add shareName param in azure file storage class
ad9d033 
skip create azure file if it exists
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/azure area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Apr 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2019
@andyzhangx andyzhangx changed the title user could specify azure file share name in azure file plugin specify azure file share name in azure file plugin Apr 24, 2019
feiskyer
feiskyer reviewed Apr 24, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 24, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 2e96bf5 into kubernetes:master Apr 24, 2019
This was referenced Apr 25, 2019
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Apr 27, 2019
@k8s-ci-robot
Merge pull request #77110 from andyzhangx/automated-cherry-pick-of-#7…
44a61d5 
…6988-upstream-release-1.12

Automated cherry pick of #76988: add shareName param in azure file storage class
k8s-ci-robot added a commit that referenced this pull request May 2, 2019
@k8s-ci-robot
Merge pull request #77042 from andyzhangx/automated-cherry-pick-of-#7…
ebf834b 
…6988-upstream-release-1.14

Automated cherry pick of #76988: add shareName param in azure file storage class
k8s-ci-robot added a commit that referenced this pull request May 3, 2019
@k8s-ci-robot
Merge pull request #77043 from andyzhangx/automated-cherry-pick-of-#7…
2831e5e 
…6988-upstream-release-1.13

Automated cherry pick of #76988: add shareName param in azure file storage class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use an existing azure file share name should be possible in azure file plugin
4 participants
@andyzhangx @k8s-ci-robot @fejta-bot @feiskyer