Skip to content

Fix eviction dry-run #76969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2019
Merged

Fix eviction dry-run #76969

merged 1 commit into from
Apr 25, 2019

Conversation

apelisse
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #76943

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes a bug where dry-run is not honored for pod/eviction sub-resource.

/assign @liggitt

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 24, 2019
@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 24, 2019
@apelisse apelisse mentioned this pull request Apr 24, 2019
Closed
10 tasks
@apelisse apelisse force-pushed the fix-dry-run-eviction branch from 257698f to 37f2663 Compare April 24, 2019 16:51
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2019
@apelisse
Copy link
Member Author

Updated, PTAL

@liggitt
Copy link
Member

liggitt commented Apr 25, 2019

/lgtm
/approve
/sig api-machinery
/priority important-soon

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 25, 2019
@liggitt liggitt added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 28172ec into kubernetes:master Apr 25, 2019
@apelisse
Copy link
Member Author

I'll cherry-pick this to the relevant branches (probably 1.13, 1.14)

@apelisse apelisse mentioned this pull request Apr 29, 2019
Merged
@apelisse apelisse mentioned this pull request Apr 29, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request May 21, 2019
@k8s-ci-robot
Merge pull request #77236 from apelisse/automated-cherry-pick-of-#769…
098854a 
…69-upstream-release-1.14

Automated cherry pick of #76969: Fix eviction dry-run
k8s-ci-robot added a commit that referenced this pull request May 30, 2019
@k8s-ci-robot
Merge pull request #77234 from apelisse/automated-cherry-pick-of-#769…
ac5aa6a 
…69-upstream-release-1.13

Automated cherry pick of #76969: Fix eviction dry-run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pods/eviction does not honor dryRun: trueoption
3 participants
@apelisse @liggitt @k8s-ci-robot