Skip to content

Pick up security patches for fluentd-gcp-scaler by upgrading to version 0.5.2 #76762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
May 2, 2019
Merged

Pick up security patches for fluentd-gcp-scaler by upgrading to version 0.5.2 #76762

k8s-ci-robot merged 1 commit into from
May 2, 2019
+1 −1

Conversation

@serathius
Copy link
Contributor

@serathius serathius commented Apr 18, 2019

/kind bug

[fluentd-gcp addon] Bump fluentd-gcp-scaler to v0.5.2 to pick up security fixes.

/assign @x13n

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 18, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 18, 2019

Hi @serathius. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 18, 2019
@k8s-ci-robot k8s-ci-robot requested review from piosz and x13n April 18, 2019 09:56
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/gcp and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 18, 2019
@x13n
Copy link
Member

x13n commented Apr 18, 2019

/lgtm
/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 18, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2019
@serathius
Copy link
Contributor Author

serathius commented Apr 19, 2019

/check-cla

1 similar comment
@serathius
Copy link
Contributor Author

serathius commented Apr 19, 2019

/check-cla

@serathius
Copy link
Contributor Author

serathius commented Apr 19, 2019

Featured command
/check-cla

@serathius
Copy link
Contributor Author

serathius commented Apr 19, 2019

/check-cla

@nikhita
Copy link
Member

nikhita commented Apr 19, 2019

@serathius the /check-cla command is not always reliable because of how the api works (related issue: kubernetes/test-infra#12265).

Closing and reopening to see if that triggers the cla bot.

@nikhita nikhita closed this Apr 19, 2019
@nikhita nikhita reopened this Apr 19, 2019
@serathius
Copy link
Contributor Author

serathius commented Apr 19, 2019

Thanks Nikhita for help. It looks like it still didn't help.
Should I repeat close/reopen until bot catches it up?

@nikhita
Copy link
Member

nikhita commented Apr 19, 2019

Should I repeat close/reopen until bot catches it up?

Unfortunately, it looks like that won't help :(

@cblecker @spiffxp @BenTheElder @dims historically, what have we done for such cases? Manually add the label if the cla/linuxfoundation status is green? IIRC we've treated this on a case-by-case basis before...

@BenTheElder
Copy link
Member

BenTheElder commented Apr 19, 2019

/check-cla

@BenTheElder
Copy link
Member

BenTheElder commented Apr 19, 2019

I'm not sure that the previous options worked other than someone clicking merge, we could get this to a new PR or possibly commit

@BenTheElder BenTheElder mentioned this pull request Apr 19, 2019
Closed
@BenTheElder
Copy link
Member

BenTheElder commented Apr 19, 2019

tested over here: #76837

doing a no-op amend to the commit fixed it

@cblecker
Copy link
Member

cblecker commented Apr 20, 2019

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2019
@serathius
Copy link
Contributor Author

serathius commented May 2, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit d2ce69d into kubernetes:master May 2, 2019
This was referenced May 2, 2019
Merged
Merged
Merged
Closed
k8s-ci-robot added a commit that referenced this pull request May 6, 2019
@k8s-ci-robot
Merge pull request #77337 from serathius/automated-cherry-pick-of-#76…
28bede9 
…762-upstream-release-1.14

Automated cherry pick of #76762: Pick up security patches for fluentd-gcp-scaler by upgrading
k8s-ci-robot added a commit that referenced this pull request May 6, 2019
@k8s-ci-robot
Merge pull request #77338 from serathius/automated-cherry-pick-of-#76…
01784d0 
…762-upstream-release-1.13

Automated cherry pick of #76762: Pick up security patches for fluentd-gcp-scaler by upgrading
k8s-ci-robot added a commit that referenced this pull request May 6, 2019
@k8s-ci-robot
Merge pull request #77339 from serathius/automated-cherry-pick-of-#76…
8f918bb 
…762-upstream-release-1.12

Automated cherry pick of #76762: Pick up security patches for fluentd-gcp-scaler by upgrading
@serathius serathius deleted the fluentd-gcp-scaler-0-5-2 branch July 11, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piosz piosz Awaiting requested review from piosz

@x13n x13n Awaiting requested review from x13n

Assignees

@x13n x13n

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serathius @k8s-ci-robot @x13n @nikhita @BenTheElder @cblecker