Delete only unscheduled pods in DaemonSetController if node doesn't exist anymore #76060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/sig apps |
k8s-ci-robot
added
sig/apps
|
/assign @k82cn |
|
/cc @k82cn |
|
/cc mikedanese |
k82cn
reviewed
Apr 7, 2019
| @@ -1537,7 +1538,9 @@ func getPodsWithoutNode(runningNodesList []*v1.Node, nodeToDaemonPods map[string | |||
| for n, pods := range nodeToDaemonPods { | |||
| if !isNodeRunning[n] { | |||
| for _, pod := range pods { | |||
| results = append(results, pod.Name) | |||
| if len(pod.Spec.NodeName) == 0 { | |||
There was a problem hiding this comment.
LGTM overall; personally, I'd like to add a comment on the scenario that DaemonSet-Controller will delete Pod without NodeName, and PodGC will delete pod has NodeName.
|
/approve |
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, krzysztof-jastrzebski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Apr 8, 2019
Merged
Merged
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 9, 2019
…-pick-of-#76060-upstream-release-1.14 Automated cherry pick of #76060: Delete only unscheduled pods if node doesn't exist anymore.
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 15, 2019
…-pick-of-#76060-upstream-release-1.12 Automated cherry pick of #76060: Delete only unscheduled pods if node doesn't exist anymore.
k8s-ci-robot
added a commit
that referenced
this pull request
May 22, 2019
…-pick-of-#76060-upstream-release-1.13 Automated cherry pick of #76060: Delete only unscheduled pods if node doesn't exist anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
PR fixes bug introduced in #73401. Behaviour is changed so DaemonSetController deletes pods for non-existing nodes only if PodGCController can't remove them (pods that haven't been scheduled before node was deleted). Previously DaemonSetController stop processing DaemonSet for 5 minutes after node removal, see #75836.
Which issue(s) this PR fixes:
Fixes #75836
Does this PR introduce a user-facing change?: