-
Notifications
You must be signed in to change notification settings - Fork 42.1k
Restore username and password kubectl flags #75451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Mar 18, 2019
Member
Author
|
/milestone v1.14 low risk, restoring compatibility break |
Contributor
|
/lgtm |
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 21, 2019
…1-upstream-release-1.12 Automated cherry pick of #75451: Restore username and password kubectl flags
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 22, 2019
…1-upstream-release-1.13 Automated cherry pick of #75451: Restore username and password kubectl flags
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 1, 2019
…1-upstream-release-1.11 Automated cherry pick of #75451: Restore username and password kubectl flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/kubectl
cherry-pick-approved
Indicates a cherry-pick PR into a release branch has been approved by the release branch manager.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
sig/auth
Categorizes an issue or PR as relevant to SIG Auth.
sig/cli
Categorizes an issue or PR as relevant to SIG CLI.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Restores username and password flags to kubectl, lost in 3ca222b#diff-d1745d70bc28d1ce59e3f8df9512084fR271
Which issue(s) this PR fixes:
Fixes #75450
Does this PR introduce a user-facing change?:
/sig cli
/sig auth
/cc @juanvallejo