Skip to content

Conversation

@liggitt
Copy link
Member

@liggitt liggitt commented Mar 18, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Restores username and password flags to kubectl, lost in 3ca222b#diff-d1745d70bc28d1ce59e3f8df9512084fR271

Which issue(s) this PR fixes:
Fixes #75450

Does this PR introduce a user-facing change?:

Restores --username and --password flags to kubectl

/sig cli
/sig auth
/cc @juanvallejo

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 18, 2019
@liggitt liggitt added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 18, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Mar 19, 2019

/milestone v1.14

low risk, restoring compatibility break

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Mar 19, 2019
@spiffxp
Copy link
Contributor

spiffxp commented Mar 19, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1d441c1 into kubernetes:master Mar 19, 2019
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 19, 2019
@liggitt liggitt deleted the kubectl-username branch March 20, 2019 01:25
k8s-ci-robot added a commit that referenced this pull request Mar 21, 2019
…1-upstream-release-1.12

Automated cherry pick of #75451: Restore username and password kubectl flags
k8s-ci-robot added a commit that referenced this pull request Mar 22, 2019
…1-upstream-release-1.13

Automated cherry pick of #75451: Restore username and password kubectl flags
k8s-ci-robot added a commit that referenced this pull request Apr 1, 2019
…1-upstream-release-1.11

Automated cherry pick of #75451: Restore username and password kubectl flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kubectl --username/--password no longer work

4 participants