Skip to content

[kube-proxy/ipvs] Do not delete existing VS and RS when starting #75283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Mar 20, 2019
Merged

[kube-proxy/ipvs] Do not delete existing VS and RS when starting #75283

k8s-ci-robot merged 1 commit into from
Mar 20, 2019

Conversation

@lbernail
Copy link
Contributor

@lbernail lbernail commented Mar 12, 2019 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Avoid graceful deletion of RS when starting the GracefulTerminationManager. By doing this, we were removing RS that had no Active/Inactive connections and setting the weight of the others to 0. This means no connection could be established until syncProxyRules ran for the first time.

I tested several cases to make sure this did not break anything:

  • turn off kube-proxy
  • delete a service
  • delete an endpoint on another service
  • restart kube-proxy

=> Everything was successfully resynced as soon as syncProxyRules ran

However, I don't have the initial context for this behavior at start-up so I may be missing something. @Lion-Wei / @m1093782566 you may have some insights?

Which issue(s) this PR fixes:
Fixes #73154

Does this PR introduce a user-facing change?:

[IPVS] Allow for transparent kube-proxy restarts

/assign @m1093782566
/sig network
/area ipvs

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. area/ipvs size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 12, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 12, 2019

Hi @lbernail. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 12, 2019
@m1093782566
Copy link
Contributor

m1093782566 commented Mar 12, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2019
@m1093782566
Copy link
Contributor

m1093782566 commented Mar 12, 2019

/lgtm

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernail, m1093782566

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2019
@lbernail
Copy link
Contributor Author

lbernail commented Mar 12, 2019

/test pull-kubernetes-integration

@lbernail
Copy link
Contributor Author

lbernail commented Mar 12, 2019

/assign @hoegaarden

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 12, 2019
@hoegaarden
Copy link
Contributor

hoegaarden commented Mar 12, 2019

Hey all.

@lbernail -- thanks for this bugfix!

It seems from a slack convo with @lbernail that this is not super urgent. My gut feeling is to not bring it into 1.14 that late. But I'll defer this to the leads of SIG-network. If we'd not include that in 1.14 that potentially also give us some time to have some tests for this issue?

@kubernetes/sig-network-bugs
@kubernetes/sig-network-pr-reviews

@k8s-ci-robot k8s-ci-robot merged commit 88dc966 into kubernetes:master Mar 20, 2019
This was referenced Mar 26, 2019
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Mar 27, 2019
@k8s-ci-robot
Merge pull request #75723 from DataDog/automated-cherry-pick-of-#7528…
babf79e 
…3-upstream-release-1.12

Automated cherry pick of #75283 upstream release 1.12
k8s-ci-robot added a commit that referenced this pull request Apr 4, 2019
@k8s-ci-robot
Merge pull request #75721 from DataDog/automated-cherry-pick-of-#7528…
b4af0fa 
…3-upstream-release-1.14

Automated cherry pick of #75283 upstream release 1.14
k8s-ci-robot added a commit that referenced this pull request Apr 4, 2019
@k8s-ci-robot
Merge pull request #75722 from DataDog/automated-cherry-pick-of-#7528…
4bb0d32 
…3-upstream-release-1.13

Automated cherry pick of #75283 upstream release 1.13
@lbernail lbernail mentioned this pull request May 13, 2019
Closed
6 tasks
@lbernail lbernail mentioned this pull request May 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lion-Wei Lion-Wei Awaiting requested review from Lion-Wei

@thockin thockin Awaiting requested review from thockin

Assignees

@hoegaarden hoegaarden

@m1093782566 m1093782566

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipvs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cluster IP will lost connection when restart kube-proxy in version 1.12.5

4 participants

@lbernail @k8s-ci-robot @m1093782566 @hoegaarden