kubeadm: fix url validation code #74454
Merged
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
Author
|
/cc @neolit123 |
k8s-ci-robot
added
area/kubeadm
sig/cluster-lifecycle
neolit123
approved these changes
Feb 23, 2019
Member
neolit123
left a comment
neolit123
left a comment
There was a problem hiding this comment.
thanks for the quick fix.
/priority critical-urgent
/kind bug
/approve
we need a backport to 1.13 (at least) after this PR merges.
@bart0sh let me know if are going to do it. else, i can too...
https://github.com/eBay/Kubernetes/blob/master/docs/devel/cherry-picks.md
k8s-ci-robot
added
priority/critical-urgent
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bart0sh, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Fixed nil pointer dereference in url validation code that
caused kubeamd panic:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0xa7930c]
goroutine 1 [running]:
kubeadm/validation.ValidateURLs(0x40000bafe0, 0x2, 0x2, 0x1, 0x40002967b0, 0x0, 0x40002967b0, 0xf302a0)
kubeadm/validation/validation.go:324 +0xcc
kubeadm/validation.ValidateEtcd(0x400000b490, 0x4000296720, 0x0, 0x0, 0x0)
kubeadm/validation/validation.go:291 +0x1f0
...
Fixes: kubernetes/kubeadm#1419
Signed-off-by: Ed Bartosh <[email protected]>
bart0sh
force-pushed
the
PR0064-kubeadm-1419-fix-ValidateURLs
branch
from
4097a5f to
f8d235b
Compare
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
lgtm
Member
|
/lgtm |
This was referenced Feb 23, 2019
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 24, 2019
…454-origin-release-1.12 Automated cherry pick of #74454: kubeadm: fix url validation code
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 26, 2019
…454-origin-release-1.13 Automated cherry pick of #74454: kubeadm: fix url validation code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixed nil pointer dereference in url validation code that
caused kubeamd panic:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0xa7930c]
goroutine 1 [running]:
kubeadm/validation.ValidateURLs(0x40000bafe0, 0x2, 0x2, 0x1, 0x40002967b0, 0x0, 0x40002967b0, 0xf302a0)
kubeadm/validation/validation.go:324 +0xcc
kubeadm/validation.ValidateEtcd(0x400000b490, 0x4000296720, 0x0, 0x0, 0x0)
kubeadm/validation/validation.go:291 +0x1f0
...
Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#1419
Does this PR introduce a user-facing change?: