Explicitly set GVK when sending objects to webhooks #74448
Merged
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
sig/api-machinery
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
liggitt
added
the
priority/important-soon
k8s-ci-robot
removed
the
needs-priority
Member
|
/assign @mbohlool |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Feb 27, 2019
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 7, 2019
…8-upstream-release-1.12 Automated cherry pick of #74448: Explicitly set GVK when sending objects to webhooks
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 19, 2019
…8-upstream-release-1.13 Automated cherry pick of #74448: Explicitly set GVK when sending objects to webhooks
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 21, 2019
…8-upstream-release-1.11 Automated cherry pick of #74448: Explicitly set GVK when sending objects to webhooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When sending typed objects (e.g. pods, configmaps, etc) to admission webhooks, the object/oldObject was missing an apiVersion/kind field.
Which issue(s) this PR fixes:
Fixes #74373
(will pick to release branches after review/merge)
Does this PR introduce a user-facing change?:
/sig api-machinery
/cc @mbohlool