Skip to content

Update to go1.10.8 #73379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Jan 31, 2019
Merged

Update to go1.10.8 #73379

k8s-ci-robot merged 2 commits into from
Jan 31, 2019

Conversation

@cblecker
Copy link
Member

@cblecker cblecker commented Jan 27, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it: updates to use go1.10.8, which fixes CVE-2019-6486.

Which issue(s) this PR fixes:
x-ref #73238

Does this PR introduce a user-facing change?:

Update to go1.10.8

/assign @BenTheElder @ixdy @foxish
/sig release
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 27, 2019
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/release Categorizes an issue or PR as relevant to SIG Release. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jan 27, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 27, 2019

@cblecker: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2019
@cblecker cblecker changed the base branch from master to release-1.11 January 27, 2019 22:44
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 27, 2019
@cblecker cblecker added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 27, 2019
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jan 27, 2019
@cblecker cblecker removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker cblecker mentioned this pull request Jan 27, 2019
Closed
5 tasks
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 27, 2019
@kubernetes kubernetes deleted a comment from k8s-ci-robot Jan 27, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 27, 2019
@cblecker
Copy link
Member Author

cblecker commented Jan 27, 2019

/retest

@ixdy
Copy link
Contributor

ixdy commented Jan 28, 2019

those failures make no sense...

/retest

ixdy
ixdy reviewed Jan 28, 2019
View reviewed changes
build/root/.bazelrc
startup --expand_configs_in_place

# don't error on error on deprecated native http_archive rule
build --incompatible_remove_native_http_archive=false
Copy link
Contributor

@ixdy ixdy Jan 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be getting removed in bazel 0.23.0, but we're pinned to an old version of bazel on CI anyway.

@ixdy
Copy link
Contributor

ixdy commented Jan 28, 2019 •
edited
Loading

wait, what?

W0128 19:35:15.704] bootstrap.py is deprecated!
Please migrate your job to podutils!
https://github.com/kubernetes/test-infra/blob/master/prow/pod-utilities.md
I0128 19:35:15.704] Args: --job=pull-kubernetes-e2e-kops-aws --service-account=/etc/service-account/service-account.json --upload=gs://kubernetes-jenkins/logs --root=/go/src --job=pull-kubernetes-e2e-kops-aws --repo=k8s.io/kubernetes=release-1.11:3a10094374f22b621b3379a2f6cb81025ffe543f,73379:1b749e7a53d79304df59fa2ddfac59e10e7b5292 --repo=k8s.io/release --service-account=/etc/service-account/service-account.json --upload=gs://kubernetes-jenkins/pr-logs --timeout=75 --scenario=kubernetes_e2e -- --aws --aws-cluster-domain=test-cncf-aws.k8s.io --build=bazel --cluster= --env=KOPS_LATEST=latest-ci-green.txt --env=KOPS_DEPLOY_LATEST_KUBE=n --env=KUBE_GCS_UPDATE_LATEST=n --env=KUBE_FASTBUILD=true --extract=local --ginkgo-parallel --provider=aws --stage=gs://kubernetes-release-pull/ci/pull-kubernetes-e2e-kops-aws '--test_args=--ginkgo.flakeAttempts=2 --ginkgo.skip=\[Slow\]|\[Serial\]|\[Disruptive\]|\[Flaky\]|\[Feature:.+\]|\[HPA\]|Dashboard|Services.*functioning.*NodePort' --timeout=55m
I0128 19:35:15.704] Bootstrap pull-kubernetes-e2e-kops-aws...
I0128 19:35:15.708] Builder: gke-prow-containerd-pool-99179761-btf8
I0128 19:35:15.709] Image: gcr.io/k8s-testimages/kubekins-e2e:v20190125-3d9554697e-master
I0128 19:35:15.709] Gubernator results at https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/73379/pull-kubernetes-e2e-kops-aws/120860
...

That's not right: gcr.io/k8s-testimages/kubekins-e2e:v20190125-3d9554697e-master

@ixdy
Copy link
Contributor

ixdy commented Jan 28, 2019

Somehow we never created branched versions of pull-kubernetes-e2e-kops-aws, pull-kubernetes-e2e-gce-device-plugin-gpu, pull-kubernetes-kubemark-e2e-gce-big, and pull-kubernetes-e2e-gce for release-1.11 and release-1.12.

@BenTheElder
Copy link
Member

BenTheElder commented Jan 28, 2019

cc @amwat

@ixdy
Copy link
Contributor

ixdy commented Jan 29, 2019

/retest

@ixdy
Copy link
Contributor

ixdy commented Jan 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2019
@ixdy
Copy link
Contributor

ixdy commented Jan 30, 2019

/retest

1 similar comment
@cblecker
Copy link
Member Author

cblecker commented Jan 30, 2019

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 30, 2019

@cblecker: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 1b749e7 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ixdy
Copy link
Contributor

ixdy commented Jan 30, 2019

/skip

@foxish foxish added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 31, 2019
@foxish foxish added this to the v1.11 milestone Jan 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit fea9872 into kubernetes:release-1.11 Jan 31, 2019
@tabern tabern mentioned this pull request Mar 18, 2019
Closed
@whereisaaron whereisaaron mentioned this pull request Mar 22, 2019
Closed
@cblecker cblecker deleted the k8s1.11-go1.10.8 branch May 6, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@mkumatag mkumatag Awaiting requested review from mkumatag

1 more reviewer

@ixdy ixdy ixdy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@foxish foxish

@BenTheElder BenTheElder

@ixdy ixdy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.11

Development

Successfully merging this pull request may close these issues.

5 participants

@cblecker @k8s-ci-robot @ixdy @BenTheElder @foxish