Skip to content

Better scale max-inflight request limits to correlate them with master VM size #73268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jan 24, 2019
Merged

Better scale max-inflight request limits to correlate them with master VM size #73268

k8s-ci-robot merged 1 commit into from
Jan 24, 2019

Conversation

@wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Jan 24, 2019 •
edited
Loading

@MaciekPytel - FYI

Scale max-inflight limits together with master VM sizes.

@wojtek-t wojtek-t added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. release-note-none Denotes a PR that doesn't merit a release note. labels Jan 24, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 24, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 24, 2019

@wojtek-t: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 24, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2019
@wojtek-t wojtek-t added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 24, 2019
@wojtek-t wojtek-t force-pushed the better_scale_inflights branch from 5301067 to d911ebb Compare January 24, 2019 14:13
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mborsz
Copy link
Member

mborsz commented Jan 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2019
@wojtek-t
Copy link
Member Author

wojtek-t commented Jan 24, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit c21f60f into kubernetes:master Jan 24, 2019
@MaciekPytel
Copy link
Contributor

MaciekPytel commented Jan 25, 2019

@wojtek-t Can we cherry-pick this? Preferable all the way to 1.11.

@wojtek-t
Copy link
Member Author

wojtek-t commented Jan 25, 2019

Yes - we should, I will create cherrypicks.

This was referenced Jan 25, 2019
Merged
Merged
@wojtek-t wojtek-t mentioned this pull request Jan 25, 2019
Merged
@wojtek-t wojtek-t added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 25, 2019
@wojtek-t
Copy link
Member Author

wojtek-t commented Jan 25, 2019

Cherrypicks are now opened.

k8s-ci-robot added a commit that referenced this pull request Jan 25, 2019
@k8s-ci-robot
Merge pull request #73310 from wojtek-t/automated-cherry-pick-of-#732…
6260c81 
…68-upstream-release-1.13

Automated cherry pick of #73268 upstream release 1.13
k8s-ci-robot added a commit that referenced this pull request Jan 29, 2019
@k8s-ci-robot
Merge pull request #73311 from wojtek-t/automated-cherry-pick-of-#732…
3b2589b 
…68-upstream-release-1.12

Automated cherry pick of #73268 upstream release 1.12
k8s-ci-robot added a commit that referenced this pull request Jan 31, 2019
@k8s-ci-robot
Merge pull request #73312 from wojtek-t/automated-cherry-pick-of-#732…
8546c0c 
…68-upstream-release-1.11

Automated cherry pick of #73268 upstream release 1.11
@wojtek-t wojtek-t deleted the better_scale_inflights branch July 19, 2019 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@nikhiljindal nikhiljindal Awaiting requested review from nikhiljindal

Assignees

@mborsz mborsz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wojtek-t @k8s-ci-robot @mborsz @MaciekPytel