Fix nil panic propagation #72856
Merged
Fix nil panic propagation #72856
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Jan 12, 2019
Member
|
/lgtm w00t!!! Thanks for all your help @liggitt |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 14, 2019
…6-upstream-release-1.12 Automated cherry pick of #72856: Fix nil panic propagation
Member
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 14, 2019
…6-upstream-release-1.13 Automated cherry pick of #72856: Fix nil panic propagation
Contributor
|
/cc @jpbetz |
Contributor
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 16, 2019
…6-upstream-release-1.10 Automated cherry pick of #72856: Fix nil panic propagation
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 17, 2019
…6-upstream-release-1.11 Automated cherry pick of #72856: Fix nil panic propagation
Member
|
So how about cherry-picking this to release 1.12? |
Member
Author
already done: #72858 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
https://github.com/kubernetes/kubernetes/pull/71076/files#diff-390e9c6b4af51b3a3723c78f40b0e134 introduced a bug in which nil could be sent to the rest panic-propagating channel.
When the response actually did panic, this code worked properly.
When the response did not panic, it would send nil, racing the err and result channels. When the panic-propagating channel won the race, a nil panic would be thrown. This would short-circuit all response writing, resulting in no content type and no status code, but maddeningly, would not be logged (because the object sent to panic was
nil).Which issue(s) this PR fixes:
Fixes #71696
Special notes for your reviewer:
@dims is a hero for tracking this down.
Does this PR introduce a user-facing change?:
/assign @dims @sttts
/sig api-machinery
/kind bug
/priority critical-urgent