Skip to content

Conversation

@feiskyer
Copy link
Member

@feiskyer feiskyer commented Jan 7, 2019

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

According to https://docs.microsoft.com/en-us/azure/azure-subscription-service-limits#load-balancer, the default limit of rules count per resource (Basic) is 250.

This PR increases maximumLoadBalancerRuleCount to 250.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Increase Azure default maximumLoadBalancerRuleCount to 250.

/sig azure
/assign @andyzhangx
cc @weinong

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/azure cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer
Copy link
Member Author

feiskyer commented Jan 7, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 7, 2019
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2019
backoffDurationDefault = 5 // in seconds
backoffJitterDefault = 1.0
// According to https://docs.microsoft.com/en-us/azure/azure-subscription-service-limits#load-balancer.
maximumLoadBalancerRuleCount = 250

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one to one mapping with a K8s service of type LoadBalancer ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one to one, or one to many. e.g. if service tags or loadBalancerSourceRanges are set, multiple rules would be created for the service

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Feiskyer,

My name's Vinicius Silva from Brazil and I'm following your commits on Kubernetes Respository, thank your for works to make better every day the Kubernetes. Today our company is a Microsoft partner and we are heaving user of AKS service. Yesterday we found a limit of LoadBalancer to use in Aks (Actual number 250) and we have a little question about.

You can help us to understand these limit? Follow the little code part about the limits of loadbalancers:

File: azure.go
line: 50: maximumLoadBalancerRuleCount = 250
line: 405
if az.MaximumLoadBalancerRuleCount == 0 {
az.MaximumLoadBalancerRuleCount = maximumLoadBalancerRuleCount
}

It's possible we use this value on flag for example? Other question is, the LoadBalancer basic are documented on Microsoft docs the limit is 250, if we use Standard version, we can use the 1500 (Rules per resouce) for example?

Image 1: Load Balancer Documentation (https://docs.microsoft.com/en-us/azure/azure-subscription-service-limits#load-balancer)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, it could be configured in azure cloud configure file. just set maximumLoadBalancerRuleCount to the new value there.

@feiskyer
Copy link
Member Author

feiskyer commented Jan 7, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8b3b5a9 into kubernetes:master Jan 7, 2019
@feiskyer feiskyer deleted the lb-rules-count branch January 7, 2019 08:32
k8s-ci-robot added a commit that referenced this pull request Apr 15, 2019
…21-upstream-release-1.12

Automated cherry pick of #72621: Increase default maximumLoadBalancerRuleCount to 250
k8s-ci-robot added a commit that referenced this pull request Apr 23, 2019
…21-upstream-release-1.11

Automated cherry pick of #72621: Increase default maximumLoadBalancerRuleCount to 250
k8s-ci-robot added a commit that referenced this pull request Apr 30, 2019
…21-upstream-release-1.13

Automated cherry pick of #72621: Increase default maximumLoadBalancerRuleCount to 250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants