-
Notifications
You must be signed in to change notification settings - Fork 42.1k
Increase default maximumLoadBalancerRuleCount to 250 #72621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/priority important-soon |
andyzhangx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
| backoffDurationDefault = 5 // in seconds | ||
| backoffJitterDefault = 1.0 | ||
| // According to https://docs.microsoft.com/en-us/azure/azure-subscription-service-limits#load-balancer. | ||
| maximumLoadBalancerRuleCount = 250 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this one to one mapping with a K8s service of type LoadBalancer ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one to one, or one to many. e.g. if service tags or loadBalancerSourceRanges are set, multiple rules would be created for the service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Feiskyer,
My name's Vinicius Silva from Brazil and I'm following your commits on Kubernetes Respository, thank your for works to make better every day the Kubernetes. Today our company is a Microsoft partner and we are heaving user of AKS service. Yesterday we found a limit of LoadBalancer to use in Aks (Actual number 250) and we have a little question about.
You can help us to understand these limit? Follow the little code part about the limits of loadbalancers:
File: azure.go
line: 50: maximumLoadBalancerRuleCount = 250
line: 405
if az.MaximumLoadBalancerRuleCount == 0 {
az.MaximumLoadBalancerRuleCount = maximumLoadBalancerRuleCount
}
It's possible we use this value on flag for example? Other question is, the LoadBalancer basic are documented on Microsoft docs the limit is 250, if we use Standard version, we can use the 1500 (Rules per resouce) for example?
Image 1: Load Balancer Documentation (https://docs.microsoft.com/en-us/azure/azure-subscription-service-limits#load-balancer)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, it could be configured in azure cloud configure file. just set maximumLoadBalancerRuleCount to the new value there.
|
/retest |
…21-upstream-release-1.12 Automated cherry pick of #72621: Increase default maximumLoadBalancerRuleCount to 250
…21-upstream-release-1.11 Automated cherry pick of #72621: Increase default maximumLoadBalancerRuleCount to 250
…21-upstream-release-1.13 Automated cherry pick of #72621: Increase default maximumLoadBalancerRuleCount to 250
What type of PR is this?
What this PR does / why we need it:
According to https://docs.microsoft.com/en-us/azure/azure-subscription-service-limits#load-balancer, the default limit of rules count per resource (Basic) is 250.
This PR increases maximumLoadBalancerRuleCount to 250.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/sig azure
/assign @andyzhangx
cc @weinong