Fix create secret docker-registry compatibility #72344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
kind/bug
liggitt
added
the
priority/critical-urgent
k8s-ci-robot
removed
the
needs-priority
k8s-ci-robot
added
area/kubectl
sig/testing
|
/cc @soltysh |
k8s-ci-robot
added
the
approved
liggitt
commented
Dec 26, 2018
| @@ -73,7 +73,7 @@ func TestSecretForDockerRegistryGenerate(t *testing.T) { | |||
| }, | |||
| expected: &v1.Secret{ | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: "foo-7566tc6mgc", | |||
| Name: "foo-548cm7fgdh", | |||
There was a problem hiding this comment.
the breaking PR changed this, this is reverting to the original value
|
LGTM 👍 |
|
Just spectacular. I’ll add a test that verifies the actual content later. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I added a stop-gap one to the test-cmd invocation |
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 6, 2019
…4-upstream-release-1.13 Automated cherry pick of #72344: Fix create secret docker-registry compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes the secrets produced by
kubectl create secret docker-registryto restore auth segment and produce the correct case.Which issue(s) this PR fixes:
Fixes kubernetes/kubectl#571
Special notes for your reviewer:
#68441 didn't preserve the json marshaling behavior of the original struct
Does this PR introduce a user-facing change?:
/assign @smarterclayton
/sig cli