fix issue: vm sku restriction policy does not work in azure disk attach/detach #71941
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
size/XS
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
feiskyer
reviewed
Dec 11, 2018
Member
feiskyer
left a comment
feiskyer
left a comment
There was a problem hiding this comment.
/lgtm
/priority important-soon
k8s-ci-robot
added
priority/important-soon
Member
|
Should it be also cherry-picked to old releases? |
This was referenced Dec 11, 2018
Contributor
|
/retest |
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 11, 2018
…1941-upstream-release-1.13 Automated cherry pick of #71941: add VMSize info in attach/detach azure disk
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 12, 2018
…1941-upstream-release-1.11 Automated cherry pick of #71941: add VMSize info in attach/detach azure disk
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 12, 2018
…1941-upstream-release-1.12 Automated cherry pick of #71941: add VMSize info in attach/detach azure disk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
add VMSize info in attach/detach azure disk to fix issue
vm sku restriction policy does not work in azure disk attach/detachPls note that only VM Availability Set has this issue, vmss won’t have this issue.
Which issue(s) this PR fixes:
Fixes #71940
Special notes for your reviewer:
vm.HardwareProfilehas onlyVMSizeinfo, it should be included in the VM update operation, otherwise if user applies vm sku restriction policy, azure disk attach/detach will always fail since there is noVMSizeinfo in the operation.Does this PR introduce a user-facing change?:
Release note:
/sig azure
/assign @feiskyer