Skip to content

Support IPVS graceful termination when deleting a service #71895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 10, 2018
Merged

Support IPVS graceful termination when deleting a service #71895

merged 5 commits into from
Dec 10, 2018

Conversation

lbernail
Copy link
Contributor

@lbernail lbernail commented Dec 9, 2018

/kind bug

What this PR does / why we need it:
Trigger graceful termination for all real servers when a service is deleted
Unbind addresses only when the VS is finally deleted

Which issue(s) this PR fixes:
Fixes #71894

Special notes for your reviewer:
I moved address unbinding from cleanLegacyBindAddr to cleanLegacyService to use the same termination logic
I modified tests accordingly: use a fake proxier in TestCleanLegacyService to be able to test for addresses bound, and add excludeCIDR to NewFakeProxier to cover the same tests.

I'm not sure if this is the best solution but we can use it as a basis for discussion.

Does this PR introduce a user-facing change?:

Support graceful termination with IPVS when deleting a service

/sig network
/area ipvs
/assign @m1093782566
cc @Lion-Wei

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. area/ipvs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 9, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @lbernail. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 9, 2018
@m1093782566
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 10, 2018
@m1093782566
Copy link
Contributor

/cc @Lion-Wei

@m1093782566
Copy link
Contributor

Good catch!

/lgtm

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernail, m1093782566

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2018
@k8s-ci-robot k8s-ci-robot merged commit 27fca55 into kubernetes:master Dec 10, 2018
This was referenced Dec 17, 2018
Merged
Closed
@lbernail lbernail mentioned this pull request Dec 28, 2018
Merged
@lbernail lbernail mentioned this pull request Dec 28, 2018
Merged
k8s-ci-robot added a commit that referenced this pull request Jan 4, 2019
@k8s-ci-robot
Merge pull request #72411 from DataDog/automated-cherry-pick-of-#71895-…
11cd7f1 
…#72106-upstream-release-1.12

Automated cherry pick of #71895 #72106 upstream release 1.12
k8s-ci-robot added a commit that referenced this pull request Jan 5, 2019
@k8s-ci-robot
Merge pull request #72409 from DataDog/automated-cherry-pick-of-#71895-…
0948f96 
…#72106-upstream-release-1.13

Automated cherry pick of #71895 #72106 upstream release 1.13
@lbernail lbernail mentioned this pull request May 13, 2019
Closed
6 tasks
@aroradaman aroradaman mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1093782566 m1093782566 Awaiting requested review from m1093782566

@thockin thockin Awaiting requested review from thockin

@Lion-Wei Lion-Wei Awaiting requested review from Lion-Wei

Assignees

@m1093782566 m1093782566

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipvs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using IPVS, service deletion does not trigger graceful termination
3 participants
@lbernail @k8s-ci-robot @m1093782566