Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include BGPConfiguration #71868

Merged
merged 1 commit into from
Dec 8, 2018
Merged

Include BGPConfiguration #71868

merged 1 commit into from
Dec 8, 2018

Conversation

satyasm
Copy link
Contributor

@satyasm satyasm commented Dec 7, 2018 •
edited
Loading

Needed for calico 2.x to 3.x upgrade.

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Without this, k8s upgrades that go from older to newer version of calico break.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Include CRD for BGPConfigurations, needed for calico 2.x to 3.x upgrade.

@satyasm
Include BGPConfiguration
6e5542a 
Needed for calico 2.x to 3.x upgrade.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 7, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @satyasm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 7, 2018
@satyasm
Copy link
Contributor Author

satyasm commented Dec 7, 2018

/assign @caseydavenport

@MrHohn
Copy link
Member

MrHohn commented Dec 7, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 7, 2018
@satyasm
Copy link
Contributor Author

satyasm commented Dec 7, 2018

/cc @jingax10

@MrHohn
Copy link
Member

MrHohn commented Dec 7, 2018

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Dec 7, 2018
@caseydavenport
Copy link
Member

Looks like a dupe of this guy: #71682

:D I'll close mine

@caseydavenport caseydavenport mentioned this pull request Dec 7, 2018
Closed
@caseydavenport
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2018
@jingax10
Copy link
Contributor

jingax10 commented Dec 8, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caseydavenport, jingax10, satyasm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@satyasm
Copy link
Contributor Author

satyasm commented Dec 8, 2018

/retest

2 similar comments
@satyasm
Copy link
Contributor Author

satyasm commented Dec 8, 2018

/retest

@satyasm
Copy link
Contributor Author

satyasm commented Dec 8, 2018

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 338824d into kubernetes:master Dec 8, 2018
This was referenced Dec 8, 2018
Merged
Merged
k8s-ci-robot referenced this pull request Dec 10, 2018
@k8s-ci-robot
Merge pull request #71882 from satyasm/automated-cherry-pick-of-#7186…
1722383 
…8-upstream-release-1.12

Include BGPConfiguration
@satyasm satyasm mentioned this pull request Dec 10, 2018
Merged
k8s-ci-robot referenced this pull request Dec 10, 2018
@k8s-ci-robot
Merge pull request #71883 from satyasm/automated-cherry-pick-of-#7186…
4322001 
…8-upstream-release-1.13

Include BGPConfiguration
k8s-ci-robot added a commit that referenced this pull request Dec 11, 2018
@k8s-ci-robot
Merge pull request #71918 from satyasm/automated-cherry-pick-of-#7186…
2649948 
…8-upstream-release-1.11

Automated cherry pick of #71868: Include BGPConfiguration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@jingax10 jingax10 Awaiting requested review from jingax10

Assignees

@caseydavenport caseydavenport

@jingax10 jingax10

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@satyasm @k8s-ci-robot @MrHohn @caseydavenport @jingax10 @fejta-bot