apply: fix detection of non-dry-run enabled servers #71854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
Member
Author
|
/sig cli |
k8s-ci-robot
added
sig/cli
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, seans3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Apply only checks that the server supports dry-run in the create path, not the update path, which is pretty bad.
apelisse
force-pushed
the
fix-dryrun-detection
branch
from
68ad459 to
f9ca4aa
Compare
k8s-ci-robot
removed
the
lgtm
Member
Author
|
/retest |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
Author
|
/retest |
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 11, 2018
…54-upstream-release-1.13 Automated cherry pick of #71854: apply: fix detection of non-dry-run enabled servers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply only checks that the server supports dry-run in the create path,
not the update path, which is pretty bad.
What type of PR is this?
What this PR does / why we need it:
Fixes a bug where apply forgets to check if the server supports dry-run
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: