Skip to content

Fix Azure node's internal IP address #71736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Dec 5, 2018
Merged

Fix Azure node's internal IP address #71736

k8s-ci-robot merged 1 commit into from
Dec 5, 2018
+132 −2

Conversation

@feiskyer
Copy link
Member

@feiskyer feiskyer commented Dec 5, 2018 •
edited
Loading

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Only use the first IP address got from instance metadata. This is because Azure CNI would set up a list of IP addresses in instance metadata, while only the first one is the Node's IP.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Need cherry pick to 1.10-1.13.

Does this PR introduce a user-facing change?:

Only use the first IP address got from instance metadata. This is because Azure CNI would set up a list of IP addresses in instance metadata, while only the first one is the Node's IP.

/sig azure
/priority critial-urgent

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/azure cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 5, 2018
@feiskyer feiskyer added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 5, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2018
@feiskyer
Copy link
Member Author

feiskyer commented Dec 5, 2018

/assign @khenidak @andyzhangx

@k8s-ci-robot k8s-ci-robot added the sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. label Dec 5, 2018
aixeshunter
aixeshunter approved these changes Dec 5, 2018
View reviewed changes
Copy link

@aixeshunter aixeshunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CecileRobertMichon CecileRobertMichon mentioned this pull request Dec 5, 2018
Closed
@karataliu
Copy link
Contributor

karataliu commented Dec 5, 2018

I doubt the issue is related to empty check removed below:
3cea6dc#diff-28e24b2bbb610464dba4602ca9e54c1eL94

Also consider the comment there:
// Fall back to ARM API if the address is empty string.
// TODO: this is a workaround because IMDS is not stable enough.
// It should be removed after IMDS fixing the issue.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2018
@feiskyer
Copy link
Member Author

feiskyer commented Dec 5, 2018

I doubt the issue is related to empty check removed below: 3cea6dc#diff-28e24b2bbb610464dba4602ca9e54c1eL94

There's no metadata response code check before, hence that may happen because calling of metadata service may be failed. PR #70353 adds the metadata response code checking, so I think it shouldn't be happening again. However, if that's still the case, current logic should report errors if the IP is empty.

@feiskyer feiskyer removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2018
@feiskyer
Fix Azure node's internal IP address
8e9af79 
Only use the first IP address got from instance metadata. This is
because Azure CNI would setup a list of IP addresses in instance metata,
while only the first one is the Node's IP.
@karataliu
Copy link
Contributor

karataliu commented Dec 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2018
@feiskyer
Copy link
Member Author

feiskyer commented Dec 5, 2018

/retest

andyzhangx
andyzhangx reviewed Dec 5, 2018
View reviewed changes
pkg/cloudprovider/providers/azure/azure_instances.go
}
}

if len(addresses) == 1 {
Copy link
Member

@andyzhangx andyzhangx Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little confused about the number, why it's 1 not 0, more comments here?

Copy link
Member Author

@feiskyer feiskyer Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hostname is already included above

@fejta-bot
Copy link

fejta-bot commented Dec 5, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit a0c2788 into kubernetes:master Dec 5, 2018
@jackfrancis jackfrancis mentioned this pull request Dec 5, 2018
Closed
@feiskyer feiskyer deleted the fix-ip branch December 6, 2018 01:15
@mboersma mboersma mentioned this pull request Dec 6, 2018
Merged
4 tasks
This was referenced Dec 6, 2018
Merged
Merged
Merged
Merged
@marc-sensenich marc-sensenich mentioned this pull request Dec 6, 2018
Closed
k8s-ci-robot added a commit that referenced this pull request Dec 7, 2018
@k8s-ci-robot
Merge pull request #71778 from feiskyer/automated-cherry-pick-of-#717…
4600add 
…36-upstream-release-1.11

Automated cherry pick of #71736: Fix Azure node's internal IP address
k8s-ci-robot added a commit that referenced this pull request Dec 8, 2018
@k8s-ci-robot
Merge pull request #71777 from feiskyer/automated-cherry-pick-of-#717…
d61eeed 
…36-upstream-release-1.12

Automated cherry pick of #71736: Fix Azure node's internal IP address
k8s-ci-robot added a commit that referenced this pull request Dec 10, 2018
@k8s-ci-robot
Merge pull request #71776 from feiskyer/automated-cherry-pick-of-#717…
190aab4 
…36-upstream-release-1.13

Automated cherry pick of #71736: Fix Azure node's internal IP address
k8s-ci-robot added a commit that referenced this pull request Dec 10, 2018
@k8s-ci-robot
Merge pull request #71779 from feiskyer/automated-cherry-pick-of-#717…
7f4e128 
…36-upstream-release-1.10

Automated cherry pick of #71736: Fix Azure node's internal IP address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khenidak khenidak Awaiting requested review from khenidak

2 more reviewers

@andyzhangx andyzhangx andyzhangx left review comments

@aixeshunter aixeshunter aixeshunter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andyzhangx andyzhangx

@karataliu karataliu

@khenidak khenidak

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@feiskyer @k8s-ci-robot @karataliu @fejta-bot @andyzhangx @aixeshunter @khenidak