Skip to content

add missing flags in *-controller-manager --help #71298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stewart-yu
Copy link
Contributor

@stewart-yu stewart-yu commented Nov 21, 2018

What type of PR is this?
/kind bug
/kind cleanup

What this PR does / why we need it:
In #67362 introduce print section part, but seems missing some global flag and cloud-provider-gce-lb-src-cidrs flag for *-controller-manager, so we add it in this PR:
part of output:

Generic flags:

      --allocate-node-cidrs                                                                           
                Should CIDRs for Pods be allocated and set on the cloud provider.
     ....
      --cloud-provider-gce-lb-src-cidrs cidrs                                                         
                CIDRs opened in GCE firewall for LB traffic proxy & health checks (default
                130.211.0.0/22,209.85.152.0/22,209.85.204.0/22,35.191.0.0/16)
      --cluster-cidr string                                                                           
                CIDR Range for Pods in cluster. Requires --allocate-node-cidrs to be true
     .....

Global flags:

      --alsologtostderr                                                                               
                log to standard error as well as files
  -h, --help                                                                                          
                help for kube-controller-manager
      --log-backtrace-at traceLocation                                                                
                when logging hits line file:N, emit a stack trace (default :0)
      --log-dir string                                                                                
                If non-empty, write log files in this directory
      --log-file string                                                                               
                If non-empty, use this log file
      --log-flush-frequency duration                                                                  
                Maximum number of seconds between log flushes (default 5s)
      --logtostderr                                                                                   
                log to standard error instead of files (default true)
      --skip-headers                                                                                  
                If true, avoid header prefixes in the log messages
      --stderrthreshold severity                                                                      
                logs at or above this threshold go to stderr (default 2)
  -v, --v Level                                                                                       
                log level for V logs
      --version version[=true]                                                                        
                Print version information and quit
      --vmodule moduleSpec                                                                            
                comma-separated list of pattern=N settings for file-filtered loggin

Similar to #70205 and #70216

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

xresf #70145

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix missing flags in *-controller-manager --help.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 21, 2018
@stewart-yu
Copy link
Contributor Author

stewart-yu commented Nov 21, 2018

/assign @sttts @imjching @luxas @andrewsykim
PTAL, we should better merge it ASAP, for kube-apiserver #70204 based on it.

@k8s-ci-robot
Copy link
Contributor

@stewart-yu: GitHub didn't allow me to assign the following users: stts, imjching.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @stts @imjching @luxas @andrewsykim
PTAL, we should better merge it ASAP, for kube-apiserver #70204 based on it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stewart-yu
Copy link
Contributor Author

/assign @sttts
/cc @imjching

@k8s-ci-robot
Copy link
Contributor

@stewart-yu: GitHub didn't allow me to request PR reviews from the following users: imjching.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @sttts
/cc @imjching

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stewart-yu
Copy link
Contributor Author

stewart-yu commented Nov 21, 2018

/cc @dims @AishSundar
has discuss with @imjching in slack , we can close #70205 and #70216. Can you add label milestone v1.13 in this PR again?

"github.com/spf13/pflag"

apiserverflag "k8s.io/apiserver/pkg/util/flag"
utilflag "k8s.io/apiserver/pkg/util/flag"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apiserverflag and utilflag are both the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@stewart-yu stewart-yu force-pushed the stewart-controller-manager-flags branch 6 times, most recently from 93f40bd to 37fe89c Compare November 21, 2018 08:50
@stewart-yu stewart-yu force-pushed the stewart-controller-manager-flags branch from 37fe89c to 97f9c6a Compare November 21, 2018 09:40
@sttts
Copy link
Contributor

sttts commented Nov 21, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stewart-yu, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2018
@stewart-yu
Copy link
Contributor Author

/priority critical-urgent
/kind bug

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/bug Categorizes issue or PR as related to a bug. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 21, 2018
@dims
Copy link
Member

dims commented Nov 21, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 21, 2018
@k8s-ci-robot k8s-ci-robot merged commit 3d5998e into kubernetes:master Nov 21, 2018
@stewart-yu stewart-yu deleted the stewart-controller-manager-flags branch November 22, 2018 00:25
@jennybuckley
Copy link

/cc @cheftako

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants