-
Notifications
You must be signed in to change notification settings - Fork 40.6k
add missing flags in *-controller-manager --help #71298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing flags in *-controller-manager --help #71298
Conversation
/assign @sttts @imjching @luxas @andrewsykim |
@stewart-yu: GitHub didn't allow me to assign the following users: stts, imjching. Note that only kubernetes members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@stewart-yu: GitHub didn't allow me to request PR reviews from the following users: imjching. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @dims @AishSundar |
"github.com/spf13/pflag" | ||
|
||
apiserverflag "k8s.io/apiserver/pkg/util/flag" | ||
utilflag "k8s.io/apiserver/pkg/util/flag" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apiserverflag
and utilflag
are both the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
93f40bd
to
37fe89c
Compare
37fe89c
to
97f9c6a
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stewart-yu, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/priority critical-urgent |
/milestone v1.13 |
/cc @cheftako |
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
In #67362 introduce print section part, but seems missing some global flag and
cloud-provider-gce-lb-src-cidrs
flag for *-controller-manager, so we add it in this PR:part of output:
Similar to #70205 and #70216
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
xresf #70145
Special notes for your reviewer:
Does this PR introduce a user-facing change?: