Rename '--experimental-encryption-provider-config' to '--encryption-provider-config' #71206

stlaz · 2018-11-19T12:03:16Z

This change renames the '--experimental-encryption-provider-config' flag to '--encryption-provider-config'. The old flag is accepted but generates a warning.

In 1.14, we will drop support for '--experimental-encryption-provider-config' entirely.

What type of PR is this?
/kind api-change

What this PR does / why we need it:
This PR follows up on the EncryptionConfiguration alpha->stable move from #67383

Which issue(s) this PR fixes:
Fixes #61420

Special notes for your reviewer:
This is a rebase of original PR #61592

Does this PR introduce a user-facing change?:

API server flag `--experimental-encryption-provider-config` was renamed to `--encryption-provider-config`. The old flag is accepted with a warning but will be removed in 1.14.

k8s-ci-robot · 2018-11-19T12:03:24Z

Hi @stlaz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

liggitt · 2018-11-19T14:37:37Z

/ok-to-test

dims · 2018-11-19T15:22:41Z

This is the alternative to #61592, 61592 was stuck behind other PRs and in rebase-hell. This does not alter the logic in any way or drop support for the older option. This just marks the older one as deprecated and adds a new option that exercises the same code as the old option

/priority critical-urgent
/milestone v1.13

dims · 2018-11-19T15:23:21Z

LGTM!

liggitt · 2018-11-19T15:28:10Z

there's a gofmt error: https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/71206/pull-kubernetes-verify/114526/

cc @smarterclayton @immutableT for evaluation (https://github.com/kubernetes/kubernetes/blob/master/OWNERS_ALIASES#L76-L78), since this is effectively graduating the encryption feature from experimental

…'--encryption-provider-config'. This change renames the '--experimental-encryption-provider-config' flag to '--encryption-provider-config'. The old flag is accepted but generates a warning. In 1.14, we will drop support for '--experimental-encryption-provider-config' entirely. Co-authored-by: Stanislav Laznicka <[email protected]>

stlaz · 2018-11-19T15:34:32Z

there's a gofmt error: https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/71206/pull-kubernetes-verify/114526/

Weird, my IDE started doing that. Fixed with vim...

liggitt · 2018-11-19T15:38:24Z

Weird, my IDE started doing that

probably a different go version (gofmt changed how indentation worked in 1.11, iirc)

stlaz · 2018-11-19T16:55:31Z

/retest

stlaz · 2018-11-20T14:58:45Z

Many thanks for LGTM and approval 🙂 Maybe we could get @mikedanese for the cluster/gce approval here?

smarterclayton · 2018-11-20T15:16:03Z

/approve

k8s-ci-robot · 2018-11-20T15:16:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~cluster/gce/gci/OWNERS~~ [smarterclayton]
~~staging/src/k8s.io/apiserver/OWNERS~~ [liggitt,smarterclayton]
~~test/OWNERS~~ [liggitt,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dims · 2018-11-20T16:51:34Z

/retest

stlaz · 2018-11-20T17:45:54Z

/retest

nikopen · 2018-11-20T18:42:12Z

/retest

nikopen · 2018-11-20T19:41:21Z

maybe this is an actual gke error / using the flag in some of their scripts?

fejta-bot · 2018-11-20T21:43:04Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

liggitt · 2018-11-20T21:43:37Z

maybe this is an actual gke error / using the flag in some of their scripts?

both the old and new flag are still accepted. the same gke error appears in other PR jobs: https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/71124/pull-kubernetes-e2e-gke/3445/

enj · 2018-11-21T00:03:45Z

/retest

AishSundar · 2018-11-21T01:29:02Z

/test pull-kubernetes-e2e-gke

AishSundar · 2018-11-21T03:11:23Z

/cc @loburm @mikedanese

@loburm we have a couple of PRs failing on pull-kubernetes-e2e-gke consistently today. Can you please help take a look to see if there's a wider GKE issue. this is critical PR blocked on getting into 1.13 release.

fejta-bot · 2018-11-21T05:25:05Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

stlaz · 2018-11-21T07:04:09Z

/retest

fejta-bot · 2018-11-21T09:58:05Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

stlaz · 2018-11-21T12:49:39Z

/retest

fejta-bot · 2018-11-21T16:16:04Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

nikopen · 2018-11-21T18:42:22Z

/retest

mikedanese · 2018-11-21T18:42:41Z

/retest

dims · 2018-11-27T14:55:48Z

cc @mayakacz

As per [this PR](kubernetes/kubernetes#71206) the flag has changed, which is a change that I proposed, even though we still support 1.14. Other things may have changed since the last change to the document in 2017, so requires better review. In addition there is a specific area for AWS. Does Azure require the same?

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 19, 2018

stlaz mentioned this pull request Nov 19, 2018

kubeapiserver: rename '--experimental-encryption-provider-config' to … #61592

Closed

k8s-ci-robot requested review from enj and jszczepkowski November 19, 2018 12:05

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 19, 2018

k8s-ci-robot added this to the v1.13 milestone Nov 19, 2018

k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 19, 2018

stlaz force-pushed the enc_config_opt branch from 815ed49 to 21c1bb8 Compare November 19, 2018 15:33

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2018

k8s-ci-robot requested review from loburm and mikedanese November 21, 2018 03:11

k8s-ci-robot merged commit 2b0212d into kubernetes:master Nov 21, 2018

Knaledge mentioned this pull request May 19, 2019

Update software versions and fix a system corruption kelseyhightower/kubernetes-the-hard-way#461

Closed

Oshratn mentioned this pull request Jan 19, 2020

Review and update Security page on docs.giantswarm giantswarm/docs#395

Merged

ialidzhikov mentioned this pull request Mar 1, 2022

apiserver: Remove the deprecated --experimental-encryption-provider-config flag #108423

Merged

stlaz mentioned this pull request Apr 1, 2022

REQUEST: New membership for stlaz kubernetes/org#3352

Closed

9 tasks

Rename '--experimental-encryption-provider-config' to '--encryption-provider-config' #71206

Rename '--experimental-encryption-provider-config' to '--encryption-provider-config' #71206

Conversation

stlaz commented Nov 19, 2018

Uh oh!

k8s-ci-robot commented Nov 19, 2018

Uh oh!

liggitt commented Nov 19, 2018

Uh oh!

dims commented Nov 19, 2018

Uh oh!

dims commented Nov 19, 2018

Uh oh!

liggitt commented Nov 19, 2018

Uh oh!

stlaz commented Nov 19, 2018

Uh oh!

liggitt commented Nov 19, 2018

Uh oh!

stlaz commented Nov 19, 2018

Uh oh!

stlaz commented Nov 20, 2018

Uh oh!

smarterclayton commented Nov 20, 2018

Uh oh!

k8s-ci-robot commented Nov 20, 2018

Uh oh!

dims commented Nov 20, 2018

Uh oh!

stlaz commented Nov 20, 2018

Uh oh!

nikopen commented Nov 20, 2018

Uh oh!

nikopen commented Nov 20, 2018

Uh oh!

fejta-bot commented Nov 20, 2018

Uh oh!

liggitt commented Nov 20, 2018

Uh oh!

enj commented Nov 21, 2018

Uh oh!

AishSundar commented Nov 21, 2018

Uh oh!

AishSundar commented Nov 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fejta-bot commented Nov 21, 2018

Uh oh!

stlaz commented Nov 21, 2018

Uh oh!

fejta-bot commented Nov 21, 2018

Uh oh!

stlaz commented Nov 21, 2018

Uh oh!

fejta-bot commented Nov 21, 2018

Uh oh!

nikopen commented Nov 21, 2018

Uh oh!

mikedanese commented Nov 21, 2018

Uh oh!

dims commented Nov 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

AishSundar commented Nov 21, 2018 •

edited

Loading