Skip to content

kubeadm: Allow customizing the image repository via flags #71135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 16, 2018
Merged

kubeadm: Allow customizing the image repository via flags #71135

k8s-ci-robot merged 1 commit into from
Nov 16, 2018

Conversation

@luxas
Copy link
Member

@luxas luxas commented Nov 16, 2018

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Based on feedback from KubeCon China.
Honestly, I thought we had this feature long time ago already.
This is a great UX improvement for those behind the GFW
(which I've now been myself the latest week).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:
This targets GA / v1.13

Does this PR introduce a user-facing change?:

kubeadm now supports the `--image-repository` flag for customizing what registry to pull images from

@kubernetes/sig-cluster-lifecycle-pr-reviews

@luxas luxas added this to the v1.13 milestone Nov 16, 2018
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 16, 2018
@luxas luxas added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 16, 2018
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm labels Nov 16, 2018
timothysc
timothysc approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

looks clean to me, but defer to @fabriziopandini if it will affect the all change in any way.

fabriziopandini
fabriziopandini approved these changes Nov 16, 2018
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luxas thanks!
/approve
/lgtm

@timothysc at first sight no interference with the other PR in flights, but I will keep an eye on merge

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, luxas, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rdodev
Copy link
Contributor

rdodev commented Nov 16, 2018

/LGTM

Thanks for quick turnaround to meet user feedback!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 16, 2018

@rdodev: changing LGTM is restricted to assignees, and only kubernetes/kubernetes repo collaborators may be assigned issues.

Details

In response to this:

/LGTM

Thanks for quick turnaround to meet user feedback!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timothysc
Copy link
Contributor

timothysc commented Nov 16, 2018

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-gce-100-performance

@AishSundar
Copy link
Contributor

AishSundar commented Nov 16, 2018

/priority critical-urgent
/remove-priority important-soon

Setting priority to critical-urgent to prevent it from getting kicked out of merge queue in case Tide doesnt get to it by Code freeze time.

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit fab7009 into kubernetes:master Nov 16, 2018
@luxas
Copy link
Member Author

luxas commented Nov 16, 2018

Thanks @AishSundar!

@zerda zerda mentioned this pull request Nov 17, 2018
Closed
@RainingNight
Copy link

RainingNight commented Nov 19, 2018

Support pod-infra-container-image?

@neolit123
Copy link
Member

neolit123 commented Nov 19, 2018

1.13 uses imageRepository for pod-infra-container-image.

@RainingNight
Copy link

RainingNight commented Nov 20, 2018

Very good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@detiber detiber Awaiting requested review from detiber

@liztio liztio Awaiting requested review from liztio

2 more reviewers

@timothysc timothysc timothysc approved these changes

@fabriziopandini fabriziopandini fabriziopandini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@timothysc timothysc

@fabriziopandini fabriziopandini

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.13

Development

Successfully merging this pull request may close these issues.

8 participants

@luxas @k8s-ci-robot @rdodev @timothysc @AishSundar @RainingNight @neolit123 @fabriziopandini