Skip to content

Remove devicePath dependency for CSI volumes #71095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 17, 2018
Merged

Remove devicePath dependency for CSI volumes #71095

k8s-ci-robot merged 1 commit into from
Nov 17, 2018
+71 −1

Conversation

@msau42
Copy link
Member

@msau42 msau42 commented Nov 15, 2018 •
edited
Loading

What type of PR is this?
/kind bug
/kind failing-test
/kind flake
@kubernetes/sig-storage-pr-reviews

What this PR does / why we need it:
CSI doesn't need the devicePath to generate the attachID

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #65246

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

ACTION REQUIRED: The Node.Status.Volumes.Attached.DevicePath fields is deprecated for CSI volumes and will be unset in a future release

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 15, 2018
@msau42
Copy link
Member Author

msau42 commented Nov 15, 2018

/hold
while testing PD driver

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2018
@msau42
Copy link
Member Author

msau42 commented Nov 15, 2018

/priority important-soon
/assign @davidz627 @saad-ali

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 15, 2018
@msau42 msau42 mentioned this pull request Nov 15, 2018
Closed
@davidz627
Copy link
Contributor

davidz627 commented Nov 15, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2018
saad-ali
saad-ali approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/milestone 1.13

Thanks @msau42!!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 15, 2018

@saad-ali: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.10, v1.11, v1.12, v1.13, v1.14, v1.4, v1.5, v1.6, v1.7, v1.8, v1.9]

Use /milestone clear to clear the milestone.

Details

In response to this:

/lgtm
/approve
/milestone 1.13

Thanks @msau42!!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2018
@saad-ali saad-ali added this to the v1.13 milestone Nov 15, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2018
@msau42
Copy link
Member Author

msau42 commented Nov 15, 2018

Fixing lint errors

@davidz627
Copy link
Contributor

davidz627 commented Nov 15, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2018
@davidz627
Copy link
Contributor

davidz627 commented Nov 15, 2018

/test pull-kubernetes-integration

@jsafrane
Copy link
Member

jsafrane commented Nov 16, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2018
@cjwagner
Copy link
Member

cjwagner commented Nov 16, 2018

Bump comment for tide status.

@msau42
Copy link
Member Author

msau42 commented Nov 16, 2018

I discussed with @jsafrane offline. devicePath has had problems in the past, and we may find more problems in the future. In general, if a plugin doesn't need to pass information between AD controller and kubelet in this way, then it should not use devicePath reduce the risk of future issues because of it. So for CSI, we should continue with this approach. @jsafrane suggested that we should also not set devicePath for CSI plugins in Node.status.volumesAttached to completely eliminate that flow from CSI. I will try this out and see if returning an empty devicePath could cause other issues.

@gnufied gnufied mentioned this pull request Nov 16, 2018
Merged
@gnufied
Copy link
Member

gnufied commented Nov 16, 2018

/lgtm

@AishSundar
Copy link
Contributor

AishSundar commented Nov 16, 2018

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 16, 2018
@msau42
Copy link
Member Author

msau42 commented Nov 16, 2018

@jsafrane I cannot remove attachID from Attach() call for another 2 releases due to backwards compatibility with older kubelets. I can deprecate it for 1.13 and we can remove it in 1.15. I've tested and saved the commit to remove attachId from Attach() here: msau42@068278f.

@msau42 msau42 mentioned this pull request Nov 16, 2018
Closed
@davidz627 davidz627 mentioned this pull request Nov 16, 2018
Closed
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2018
@msau42
Copy link
Member Author

msau42 commented Nov 16, 2018

Opened #71164 to track the AD controller work

@davidz627
Copy link
Contributor

davidz627 commented Nov 16, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2018
@saad-ali
Copy link
Member

saad-ali commented Nov 16, 2018

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AishSundar
Copy link
Contributor

AishSundar commented Nov 17, 2018

/remove-priority important-soon

@k8s-ci-robot k8s-ci-robot removed the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 17, 2018
@k8s-ci-robot k8s-ci-robot merged commit 4821291 into kubernetes:master Nov 17, 2018
@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 17, 2018
This was referenced Nov 28, 2018
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 29, 2018
@k8s-ci-robot
Merge pull request #71523 from msau42/automated-cherry-pick-of-#71095…
ad19810 
…-upstream-release-1.12

Automated cherry pick of #71095: Remove devicePath dependency for CSI volumes
@msau42 msau42 deleted the csi-devicepath branch October 19, 2019 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@rootfs rootfs Awaiting requested review from rootfs

1 more reviewer

@saad-ali saad-ali saad-ali approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gnufied gnufied

@davidz627 davidz627

@saad-ali saad-ali

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.13

Development

Successfully merging this pull request may close these issues.

Second Pod Using Same PVC Fails WaitForAttach Flakily

9 participants

@msau42 @davidz627 @k8s-ci-robot @q6413260 @jsafrane @cjwagner @gnufied @AishSundar @saad-ali