Skip to content

Update cAdvisor godeps to v0.32.0 #70964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2018
Merged

Update cAdvisor godeps to v0.32.0 #70964

merged 1 commit into from
Nov 13, 2018

Conversation

dashpole
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This updates the cAdvisor godep to v0.32.0. cAdvisor has a release corresponding to each kubernetes release.

Special notes for your reviewer:
This doesn't actually change any files since #70889 already updated cAdvisor for this release, but not to the release tag.

Does this PR introduce a user-facing change?:

NONE

/assign @dchen1107
/priority important-soon
/sig node

This should be in 1.13

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Nov 12, 2018
@dims
Copy link
Member

dims commented Nov 12, 2018

/milestone v1.13
/lgtm

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 12, 2018
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2018
@dchen1107
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dchen1107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 89bdc42 into kubernetes:master Nov 13, 2018
@dashpole dashpole deleted the update_cadvisor_godep_v0.32.0 branch November 13, 2018 17:55
@marpaia marpaia mentioned this pull request Dec 3, 2018
Merged
@cirocosta cirocosta mentioned this pull request Mar 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@jbeda jbeda Awaiting requested review from jbeda

Assignees

@dims dims

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.
5 participants
@dashpole @dims @dchen1107 @k8s-ci-robot @fejta-bot