Skip to content

Upgrade Stackdriver Logging Agent addon image to 0.6-1.6.0-1 to use Fluentd v1.2. #70954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2018
Merged

Upgrade Stackdriver Logging Agent addon image to 0.6-1.6.0-1 to use Fluentd v1.2. #70954

merged 1 commit into from
Nov 26, 2018

Conversation

qingling128
Copy link
Contributor

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Upgrade Stackdriver Logging Agent addon image to 0.6-1.6.0-1 to use Fluentd v1.2.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Upgrade Stackdriver Logging Agent addon image to 0.6-1.6.0-1 to use Fluentd v1.2. This provides nanoseconds timestamp granularity for logs.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 12, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @qingling128. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/gcp and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 12, 2018
@k8s-ci-robot k8s-ci-robot requested review from piosz and vishh November 12, 2018 18:23
@qingling128
Copy link
Contributor Author

/assign @vishh @x13n

@x13n
Copy link
Member

x13n commented Nov 13, 2018

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 13, 2018
@x13n
Copy link
Member

x13n commented Nov 13, 2018

/approve

@qingling128
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-100-performance

@qingling128
Copy link
Contributor Author

@x13n - Any chance you could help with the Must be in milestone v1.13. blocker?

@x13n
Copy link
Member

x13n commented Nov 15, 2018

I cannot add this to the milestone myself. Also, note that you still need cluster/gce/OWNERS approval.

@AishSundar Is it possible to add this PR to 1.13 milestone, given that change is GCP-specific and doesn't affect non-GCP code?

@qingling128
Copy link
Contributor Author

Could someone (from cluster/gce/OWNERS) help take a look at this PR? @vishh @MaciekPytel

@qingling128
Copy link
Contributor Author

Friendly ping.
@AishSundar @vishh @MaciekPytel

@vishh
Copy link
Contributor

vishh commented Nov 26, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qingling128, vishh, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2018
@vishh vishh added this to the v1.13 milestone Nov 26, 2018
@AishSundar
Copy link
Contributor

/kind bug
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 26, 2018
@k8s-ci-robot k8s-ci-robot merged commit 396271c into kubernetes:master Nov 26, 2018
This was referenced Nov 27, 2018
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 30, 2018
@k8s-ci-robot
Merge pull request #71442 from qingling128/automated-cherry-pick-of-#…
f7a5f79 
…70954-upstream-release-1.12

Automated cherry pick of #70954: Upgrade Stackdriver Logging Agent addon image to 0.6-1.6.0-1
k8s-ci-robot added a commit that referenced this pull request Nov 30, 2018
@k8s-ci-robot
Merge pull request #71444 from qingling128/automated-cherry-pick-of-#…
deae5dc 
…70954-upstream-release-1.10

Automated cherry pick of #70954: Upgrade Stackdriver Logging Agent addon image to 0.6-1.6.0-1
@marpaia marpaia mentioned this pull request Dec 3, 2018
Merged
k8s-ci-robot added a commit that referenced this pull request Dec 3, 2018
@k8s-ci-robot
Merge pull request #71443 from qingling128/automated-cherry-pick-of-#…
31df51d 
…70954-upstream-release-1.11

Automated cherry pick of #70954: Upgrade Stackdriver Logging Agent addon image to 0.6-1.6.0-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piosz piosz Awaiting requested review from piosz

@vishh vishh Awaiting requested review from vishh

Assignees

@x13n x13n

@vishh vishh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.
5 participants
@qingling128 @k8s-ci-robot @x13n @vishh @AishSundar