Skip to content

add log_file option to kubelet flags #70917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 16, 2018
Merged

add log_file option to kubelet flags #70917

k8s-ci-robot merged 1 commit into from
Nov 16, 2018
+1 −0

Conversation

@dims
Copy link
Member

@dims dims commented Nov 11, 2018 •
edited
Loading

Change-Id: I5e75902739e2f869244d1b8b229be2580aca8149

What type of PR is this?
/kind bug

What this PR does / why we need it:
klog supports a log-file option, make sure kubelet command line help options show this new option

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubelet now supports `log-file` option to write logs directly to a specific file

@dims
add log_file option to kubelet flags
cf142a2 
Change-Id: I5e75902739e2f869244d1b8b229be2580aca8149
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 11, 2018
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 11, 2018
@dims
Copy link
Member Author

dims commented Nov 11, 2018

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 11, 2018
@dims
Copy link
Member Author

dims commented Nov 12, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 12, 2018
@dims
Copy link
Member Author

dims commented Nov 16, 2018

/assign @yujuhong
/assign @Random-Liu

@yujuhong
Copy link
Contributor

yujuhong commented Nov 16, 2018

@dims I think I missed the announcement on klog. Could you point me to docs explaining why we're doing this? Thank you.

Why is this needed for 1.13? :-)

@dims
Copy link
Member Author

dims commented Nov 16, 2018 •
edited
Loading

@yujuhong you missed a whole bunch :)

https://groups.google.com/d/msg/kubernetes-dev/7vnijOMhLS0/1oRiNtigBgAJ

TL;DR klog now supports this option and we should expose it. ( cc @tallclair )

@yujuhong
Copy link
Contributor

yujuhong commented Nov 16, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2018
@yujuhong
Copy link
Contributor

yujuhong commented Nov 16, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit 5ec9349 into kubernetes:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@tmrts tmrts Awaiting requested review from tmrts

Assignees

@Random-Liu Random-Liu

@yujuhong yujuhong

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.13

Development

Successfully merging this pull request may close these issues.

4 participants

@dims @yujuhong @k8s-ci-robot @Random-Liu