Skip to content

CoreDNS should not tolerate master taints #70868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 16, 2018
Merged

CoreDNS should not tolerate master taints #70868

k8s-ci-robot merged 1 commit into from
Nov 16, 2018
+0 −6

Conversation

@justinsb
Copy link
Member

@justinsb justinsb commented Nov 9, 2018

Otherwise users will be surprised when CoreDNS starts running on their
masters, where kube-dns did not.

Issue #70851

/kind bug

For kube-up and derived configurations, CoreDNS will honor master taints, for consistency with kube-dns behavior.

@justinsb
CoreDNS should respect user taints
0d57176 
Otherwise users will be surprised when CoreDNS starts running on their
masters, where kube-dns did not.

Issue kubernetes#70851
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 9, 2018
@k8s-ci-robot k8s-ci-robot requested review from MrHohn and bowei November 9, 2018 14:27
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 9, 2018
@justinsb justinsb changed the title CoreDNS should respect user taints CoreDNS should respect master taints Nov 9, 2018
@justinsb justinsb changed the title CoreDNS should respect master taints CoreDNS should not tolerate master taints Nov 9, 2018
@MrHohn
Copy link
Member

MrHohn commented Nov 9, 2018

/assign @chrisohaver @rajansandeep

@MrHohn
Copy link
Member

MrHohn commented Nov 9, 2018

xref #54945

@MrHohn
Copy link
Member

MrHohn commented Nov 9, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2018
rajansandeep
rajansandeep approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@rajansandeep rajansandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2018
@rajansandeep
Copy link
Contributor

rajansandeep commented Nov 9, 2018

/retest

@fejta-bot
Copy link

fejta-bot commented Nov 9, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@justinsb justinsb added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 10, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 10, 2018
@justinsb
Copy link
Member Author

justinsb commented Nov 10, 2018

Can we triage into milestone 1.13 - not sure who should make that call - @roberthbailey or @thockin ?

I think there might actually be a case for only running on the master (as proposed in #54945), once we have the DNS node-local agent that @prameshj is working on in #70555. But the node-local agent needs time to bake before we make that decision, IMO.

@bowei
Copy link
Member

bowei commented Nov 15, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 15, 2018
@fejta-bot
Copy link

fejta-bot commented Nov 16, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 29eb75b into kubernetes:master Nov 16, 2018
This was referenced Nov 16, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bowei bowei Awaiting requested review from bowei

@MrHohn MrHohn Awaiting requested review from MrHohn

1 more reviewer

@rajansandeep rajansandeep rajansandeep approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chrisohaver chrisohaver

@rajansandeep rajansandeep

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.13

Development

Successfully merging this pull request may close these issues.

7 participants

@justinsb @MrHohn @k8s-ci-robot @rajansandeep @fejta-bot @bowei @chrisohaver