Skip to content

kubeadm: Remove AuditPolicyConfiguration #70807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 12, 2018
Merged

kubeadm: Remove AuditPolicyConfiguration #70807

k8s-ci-robot merged 1 commit into from
Nov 12, 2018

Conversation

@Klaven
Copy link
Contributor

@Klaven Klaven commented Nov 8, 2018 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Per office hours we decided to remove this. see kubernetes/kubeadm#1221
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kubernetes/kubeadm#1221

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubeadm: remove the AuditPolicyConfiguration feature gate

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 8, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 8, 2018

Hi @Klaven. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 8, 2018
@Klaven
Copy link
Contributor Author

Klaven commented Nov 8, 2018

@chuckha This is the PR we where talking about in office hours.

Klaven
Klaven commented Nov 8, 2018
View reviewed changes
cmd/kubeadm/app/phases/controlplane/manifests_test.go Outdated
Copy link
Contributor Author

@Klaven Klaven Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting and I wonder if the correct answer is to remove this test? Originally yesterday it was HA and auditing are enabled Someone else removed the HA part and then I removed the auditing. If I don't remove the test, what should the tests name be? "Pretty standard bland test"? :)

Copy link
Member

@neolit123 neolit123 Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for removal.

Copy link
Contributor Author

@Klaven Klaven Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing.

@Klaven Klaven changed the title fixes kubeadm 1221 to remove AuditPolicyConfiguration [WIP] fixes kubeadm 1221 to remove AuditPolicyConfiguration Nov 8, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2018
@neolit123
Copy link
Member

neolit123 commented Nov 8, 2018

@Klaven as mentioned earlier, we do not include the issue that a PR fixes in the PR title.

neolit123
neolit123 reviewed Nov 8, 2018
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the WIP is LGTM on a quick look.

cmd/kubeadm/app/phases/controlplane/manifests_test.go Outdated
Copy link
Member

@neolit123 neolit123 Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for removal.

@neolit123
Copy link
Member

neolit123 commented Nov 8, 2018

/priority important-soon
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 8, 2018
@Klaven Klaven changed the title [WIP] fixes kubeadm 1221 to remove AuditPolicyConfiguration [WIP] Remove AuditPolicyConfiguration Nov 8, 2018
@Klaven
Copy link
Contributor Author

Klaven commented Nov 8, 2018

I missed updating a test somehow. will also update that with the new tests that are being added.

@Klaven
Copy link
Contributor Author

Klaven commented Nov 8, 2018

@Klaven as mentioned earlier, we do not include the issue that a PR fixes in the PR title.

sorry. old habits die hard. my bad.

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Nov 8, 2018
neolit123
neolit123 reviewed Nov 8, 2018
View reviewed changes
pkg/scheduler/apis/config/v1alpha1/BUILD Outdated
Copy link
Member

@neolit123 neolit123 Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think this PR should be touching pkg/scheduler.
is this the result of ./hack/update-bazel.sh?

Copy link
Contributor Author

@Klaven Klaven Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. I think so. I have just updated this. I don't know how it got touched. I caught this too. 🤔

Copy link
Contributor Author

@Klaven Klaven Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly I squashed because I did another rebase on master and was not thinking about leaving the new commits there. my bad.

timothysc
timothysc approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/test pull-kubernetes-e2e-gce-100-performance

Once @luxas comments are addressed LGTM

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2018
fabriziopandini
fabriziopandini approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Klaven well done!

@lucas comment are addressed, so
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, Klaven, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member

neolit123 commented Nov 9, 2018

/retest

@fejta-bot
Copy link

fejta-bot commented Nov 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

4 similar comments
@fejta-bot
Copy link

fejta-bot commented Nov 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

fejta-bot commented Nov 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

fejta-bot commented Nov 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

fejta-bot commented Nov 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2018
@timothysc
Copy link
Contributor

timothysc commented Nov 12, 2018

@Klaven needs a rebase.

@neolit123
Copy link
Member

neolit123 commented Nov 12, 2018

xref: kubernetes/kubeadm#911

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 12, 2018
@neolit123
Copy link
Member

neolit123 commented Nov 12, 2018

/retest

@Klaven
fixes kubeadm 1221 to remove AuditPolicyConfiguration
064f74b 
Added conversion test and failure.
@neolit123
Copy link
Member

neolit123 commented Nov 12, 2018

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 12, 2018
@neolit123
Copy link
Member

neolit123 commented Nov 12, 2018

/hold cancel
all comments seem to be addressed
@Klaven, thanks.

if there is anything else we can revisit in a new PR.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit 3c5c602 into kubernetes:master Nov 12, 2018
@Klaven Klaven mentioned this pull request Feb 7, 2019
Closed
6 tasks
@SataQiu SataQiu mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@neolit123 neolit123 neolit123 left review comments

@luxas luxas luxas left review comments

@timothysc timothysc timothysc approved these changes

@fabriziopandini fabriziopandini fabriziopandini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@timothysc timothysc

@neolit123 neolit123

@fabriziopandini fabriziopandini

@luxas luxas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.13

Development

Successfully merging this pull request may close these issues.

Remove AuditPolicyConfiguration from config

7 participants

@Klaven @k8s-ci-robot @neolit123 @fejta-bot @timothysc @fabriziopandini @luxas