Skip to content

kubeadm: prepull Etcd image only if required #70743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2018
Merged

kubeadm: prepull Etcd image only if required #70743

merged 1 commit into from
Nov 12, 2018

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Nov 7, 2018

What type of PR is this?

/kind bug

What this PR does / why we need it:

Prepull Etcd image only if external Etcd is not used and
--etcd-upgrade=false is not specified.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes: kubernetes/kubeadm#1214

Does this PR introduce a user-facing change?:

kubeadm pre-pulls Etcd image only if external Etcd is not used and
--etcd-upgrade=false is not specified

@bart0sh
kubeadm: prepull Etcd image only if required
328c182 
Prepull Etcd image only if external Etcd is not used and
--etcd-upgrade=false is not specified.

Fixes: kubernetes/kubeadm#1214
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 7, 2018
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 7, 2018
@bart0sh
Copy link
Contributor Author

bart0sh commented Nov 7, 2018

/cc youyongsong

@k8s-ci-robot
Copy link
Contributor

@bart0sh: GitHub didn't allow me to request PR reviews from the following users: youyongsong.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc youyongsong

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bart0sh
Copy link
Contributor Author

bart0sh commented Nov 7, 2018

/cc @youyongsong

@k8s-ci-robot
Copy link
Contributor

@bart0sh: GitHub didn't allow me to request PR reviews from the following users: youyongsong.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @youyongsong

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rosti
Copy link
Contributor

rosti commented Nov 7, 2018

Actually, the problem here is a bit more fundamental I think. During init/join we have a pre-flight check that pulls images sequentially, using the GetAllImages function to get the image list. This results in control plane images, kube-proxy, etcd (if local), DNS and pause images to be pre-pulled.

With upgrade, things are different. Only control plane and etcd (if local) images are pre-pulled via the PrepullImagesInParallel func even though DNS and kube-proxy are upgraded too. Pause is not dealt with during upgrade (even though its version can change too).

I do think, that we can have some code sharing between init/join and upgrade. Probably I should spend some time preparing a cleanup PR for this.

@neolit123
Copy link
Member

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 7, 2018
@neolit123
Copy link
Member

/lgtm
/retest

@rosti @bart0sh
follow up PRs are welcome!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2018
@bart0sh
Copy link
Contributor Author

bart0sh commented Nov 9, 2018

/assign @timothysc

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 12, 2018
timothysc
timothysc approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/milestone v1.13

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit b99c8b9 into kubernetes:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc approved these changes

@detiber detiber Awaiting requested review from detiber

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@timothysc timothysc

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

kubeadm upgrade will still pre-pull etcd image when specified --etcd-upgrade=false
5 participants
@bart0sh @k8s-ci-robot @rosti @neolit123 @timothysc