Skip to content

Filter out spammy audit logs from cluster autoscaler. #70696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Nov 7, 2018
Merged

Filter out spammy audit logs from cluster autoscaler. #70696

k8s-ci-robot merged 1 commit into from
Nov 7, 2018
+7 −0

Conversation

@loburm
Copy link
Contributor

@loburm loburm commented Nov 6, 2018 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Cluster autoscaler checks endpoint every second and then updates it. It doesn't have any sense to audit log those calls.

Does this PR introduce a user-facing change?:

[GCE] Filter out spammy audit logs from cluster autoscaler.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 6, 2018
@loburm
Copy link
Contributor Author

loburm commented Nov 6, 2018

/assign @x13n @kgolab

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Nov 6, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 6, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 6, 2018

@loburm: GitHub didn't allow me to assign the following users: kgolab.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

Details

In response to this:

/assign @x13n @kgolab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kgolab
Copy link
Contributor

kgolab commented Nov 6, 2018

For all it's worth: LGTM

@x13n
Copy link
Member

x13n commented Nov 6, 2018

/lgtm
@destijl FYI

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2018
@loburm
Copy link
Contributor Author

loburm commented Nov 7, 2018

/assign @MaciekPytel

@MaciekPytel
Copy link
Contributor

MaciekPytel commented Nov 7, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: loburm, MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2018
@loburm
Copy link
Contributor Author

loburm commented Nov 7, 2018

/retest

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit 9844baa into kubernetes:master Nov 7, 2018
This was referenced Nov 22, 2018
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 28, 2018
@k8s-ci-robot
Merge pull request #71346 from loburm/automated-cherry-pick-of-#70696…
824ebfa 
…-upstream-release-1.12

Automated cherry pick of #70696: Filter out spammy audit logs from cluster autoscaler.
k8s-ci-robot added a commit that referenced this pull request Dec 3, 2018
@k8s-ci-robot
Merge pull request #71345 from loburm/automated-cherry-pick-of-#70696…
742fcc5 
…-upstream-release-1.11

Automated cherry pick of #70696: Filter out spammy audit logs from cluster autoscaler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jszczepkowski jszczepkowski Awaiting requested review from jszczepkowski

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@x13n x13n

@MaciekPytel MaciekPytel

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@loburm @k8s-ci-robot @kgolab @x13n @MaciekPytel