Upgrade golang.org/x/net image to release-branch.go1.10 #70663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
Member
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
Contributor
Author
|
/test pull-kubernetes-node-e2e |
Contributor
Author
|
/assign @bsalamat Would you please help to review this PR? Thanks! |
wenjiaswe
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
bsalamat
reviewed
Nov 6, 2018
Member
bsalamat
left a comment
bsalamat
left a comment
There was a problem hiding this comment.
/approve
There are a lot of changes that look mechanical, but still are beyond my knowledge of Go. It would be great if someone more familiar with them could take a look as well. As far as the scheduler changes are concerned, you have my approval.
Contributor
Author
Contributor
Author
|
/cc @lavalamp |
lavalamp
reviewed
Nov 6, 2018
Contributor
There was a problem hiding this comment.
Why did this file get deleted?
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this, filed a bug on this: #70711
lavalamp
reviewed
Nov 6, 2018
Godeps/Godeps.json
Outdated
Contributor
There was a problem hiding this comment.
It seems like there's unrelated changes here in the godeps file?
Contributor
Author
There was a problem hiding this comment.
Thanks! I went back and checked all the file, now should be alright. PTAL.
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
Author
|
/test pull-kubernetes-e2e-gce-100-performance |
Contributor
|
/lgtm |
Contributor
k8s-ci-robot
added
approved
This was referenced Nov 7, 2018
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 28, 2018
…663-upstream-release-1.12 Automated cherry pick of #70663: update godeps for golang.org/x/net/... to
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 3, 2018
…663-upstream-release-1.11 Automated cherry pick of #70663: update godeps for golang.org/x/net/... to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
https://go-review.googlesource.com/c/go/+/71611/ is a bundle fix for golang/go#21466, go/net release-branch.go1.10 is the next stable release that contains all the bundle fix, update the image will pick up the fix.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
golang/go#21466
Special notes for your reviewer:
As an official release branch, release-branch.go1.10 is more widely tested so I think it's less risky than PR #70632 and PR #70634 https://github.com/golang/net/compare/1c05540f6879653db88113bc4a2b70aec4bd491f..release-branch.go1.10
Does this PR introduce a user-facing change?: