Skip to content

Add socket-based kubelet pod resources API. #70508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 4 commits into from
Nov 15, 2018
Merged

Add socket-based kubelet pod resources API. #70508

k8s-ci-robot merged 4 commits into from
Nov 15, 2018

Conversation

@dashpole
Copy link
Contributor

@dashpole dashpole commented Oct 31, 2018 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
This introduces a new kubelet socket, which provides read-only information about pods, and serves a grpc service. The initial use-case for this is to support out-of-tree monitoring agents, which need to be able to correlate devices and containers.

Which issue(s) this PR fixes:
Feature Issue: kubernetes/enhancements#606
KEP: kubernetes/community#2454

Special notes for your reviewer:
The API is in pkg/kubelet/apis/podresources/v1alpha1.
This adds to the device plugin e2e_node test to test its functionality.

Add a kubelet socket which serves an grpc service containing the devices used by containers on the node.

cc @RenaudWasTaken @jiayingz @vikaschoudhary16 @vishh @derekwaynecarr
cc @kubernetes/sig-node-api-reviews

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 31, 2018
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 31, 2018
@dashpole dashpole force-pushed the pod_resources_socket branch 2 times, most recently from 8a25e13 to 471dc83 Compare October 31, 2018 22:45
@dashpole
Copy link
Contributor Author

dashpole commented Oct 31, 2018

cc @guptaNswati

@dashpole dashpole force-pushed the pod_resources_socket branch from 471dc83 to 9ab0430 Compare November 1, 2018 00:27
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 1, 2018
@dashpole dashpole force-pushed the pod_resources_socket branch 2 times, most recently from 3cc8627 to e184c99 Compare November 1, 2018 16:32
@dashpole dashpole mentioned this pull request Nov 1, 2018
Merged
@dashpole dashpole force-pushed the pod_resources_socket branch from e184c99 to 954fc48 Compare November 1, 2018 17:17
@dashpole dashpole mentioned this pull request Nov 9, 2018
Closed
4 tasks
@jeremyeder
Copy link

jeremyeder commented Nov 9, 2018

@vikaschoudhary16 can you take a look?

@dashpole dashpole force-pushed the pod_resources_socket branch from 954fc48 to 23d67c6 Compare November 9, 2018 22:13
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 9, 2018
@dashpole dashpole force-pushed the pod_resources_socket branch from 23d67c6 to a1dbd5f Compare November 9, 2018 22:39
@dashpole
Copy link
Contributor Author

dashpole commented Nov 9, 2018

/assign @vikaschoudhary16 @vishh

@dashpole dashpole force-pushed the pod_resources_socket branch from a1dbd5f to a91dc28 Compare November 9, 2018 22:54
@k8s-ci-robot k8s-ci-robot merged commit 7b4d4bc into kubernetes:master Nov 15, 2018
@dashpole dashpole deleted the pod_resources_socket branch November 15, 2018 21:46
@nikopen nikopen mentioned this pull request Nov 21, 2018
Merged
@ChiuWang ChiuWang mentioned this pull request Nov 26, 2018
Merged
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Dec 5, 2018
@ahalimx86
add kubelet client for Pod resource info
6708bed 
This change introduces kubelt client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Dec 5, 2018
@ahalimx86
add kubelet client for Pod resource info
f8a5384 
This change introduces kubelt client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Dec 5, 2018
@ahalimx86
add kubelet client for Pod resource info
9583150 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Jan 3, 2019
@ahalimx86
add kubelet client for Pod resource info
e1adcdb 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Jan 3, 2019
@ahalimx86
add kubelet client for Pod resource info
cd6d30a 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Jan 7, 2019
@ahalimx86
add kubelet client for Pod resource info
5967e82 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Jan 8, 2019
@ahalimx86
add kubelet client for Pod resource info
6392987 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Jan 8, 2019
@ahalimx86
add kubelet client for Pod resource info
8f9abf5 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
Signed-off-by: Abdul Halim <[email protected]>
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Jan 8, 2019
@ahalimx86
add kubelet client for Pod resource info
1ba9062 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
Signed-off-by: Abdul Halim <[email protected]>
@ahalimx86 ahalimx86 mentioned this pull request Jan 8, 2019
Merged
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Jan 8, 2019
@ahalimx86
add kubelet client for Pod resource info
cc5c0f5 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
Signed-off-by: Abdul Halim <[email protected]>
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Jan 9, 2019
@ahalimx86
add kubelet client for Pod resource info
7304cfa 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
Signed-off-by: Abdul Halim <[email protected]>
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Jan 9, 2019
@ahalimx86
add kubelet client for Pod resource info
32a3a7c 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
Signed-off-by: Abdul Halim <[email protected]>
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Feb 7, 2019
@ahalimx86
add kubelet client for Pod resource info
b18c5c4 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
[kubernetes/kubernetes#70508](kubernetes/kubernetes#70508)

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc
Signed-off-by: Abdul Halim <[email protected]>
@guptaNswati guptaNswati mentioned this pull request Mar 5, 2019
Closed
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Mar 20, 2019
@ahalimx86
add kubelet client for Pod resource info
38c0aae 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
[kubernetes/kubernetes#70508](kubernetes/kubernetes#70508)

Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc
Signed-off-by: Abdul Halim <[email protected]>
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Mar 20, 2019
@ahalimx86
add kubelet client for Pod resource info
957de54 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
[kubernetes/kubernetes#70508](kubernetes/kubernetes#70508)

Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc
Signed-off-by: Abdul Halim <[email protected]>
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Mar 20, 2019
@ahalimx86
add kubelet client for Pod resource info
032237a 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
[kubernetes/kubernetes#70508](kubernetes/kubernetes#70508)

Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc
Signed-off-by: Abdul Halim <[email protected]>
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Mar 21, 2019
@ahalimx86
add kubelet client for Pod resource info
78db614 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
[kubernetes/kubernetes#70508](kubernetes/kubernetes#70508)

Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc
Signed-off-by: Abdul Halim <[email protected]>
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Mar 22, 2019
@ahalimx86
add kubelet client for Pod resource info
f92f2da 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
[kubernetes/kubernetes#70508](kubernetes/kubernetes#70508)

Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc
Signed-off-by: Abdul Halim <[email protected]>
ahalimx86 added a commit to ahalimx86/multus-cni that referenced this pull request Mar 22, 2019
@ahalimx86
add kubelet client for Pod resource info
97c195b 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
[kubernetes/kubernetes#70508](kubernetes/kubernetes#70508)

Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc
Signed-off-by: Abdul Halim <[email protected]>
dougbtv pushed a commit to k8snetworkplumbingwg/multus-cni that referenced this pull request Mar 22, 2019
@ahalimx86 @dougbtv
add kubelet client for Pod resource info
d3c92b4 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
[kubernetes/kubernetes#70508](kubernetes/kubernetes#70508)

Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc
Signed-off-by: Abdul Halim <[email protected]>
zshi-redhat pushed a commit to zshi-redhat/multus-cni that referenced this pull request Mar 22, 2019
@ahalimx86 @zshi-redhat
add kubelet client for Pod resource info
9a98cf7 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
[kubernetes/kubernetes#70508](kubernetes/kubernetes#70508)

Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc
Signed-off-by: Abdul Halim <[email protected]>
(cherry picked from commit d3c92b4)
s1061123 pushed a commit to k8snetworkplumbingwg/multus-cni that referenced this pull request Mar 23, 2019
@ahalimx86 @s1061123
add kubelet client for Pod resource info
942ad47 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
[kubernetes/kubernetes#70508](kubernetes/kubernetes#70508)

Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc
Signed-off-by: Abdul Halim <[email protected]>
(cherry picked from commit d3c92b4)
zshi-redhat pushed a commit to zshi-redhat/multus-cni-1 that referenced this pull request Mar 24, 2019
@ahalimx86 @zshi-redhat
add kubelet client for Pod resource info
d2a02a6 
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
[kubernetes/kubernetes#70508](kubernetes/kubernetes#70508)

Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc
Signed-off-by: Abdul Halim <[email protected]>
(cherry picked from commit d3c92b4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims

@rohitagarwal003 rohitagarwal003 Awaiting requested review from rohitagarwal003

3 more reviewers

@vishh vishh vishh left review comments

@RenaudWasTaken RenaudWasTaken RenaudWasTaken approved these changes

@jiayingz jiayingz jiayingz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RenaudWasTaken RenaudWasTaken

@vishh vishh

@vikaschoudhary16 vikaschoudhary16

@jiayingz jiayingz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.13

Development

Successfully merging this pull request may close these issues.

10 participants

@dashpole @jeremyeder @AishSundar @k8s-ci-robot @vishh @dchen1107 @jiayingz @dims @RenaudWasTaken @vikaschoudhary16