default api audiences to service account token issuer if available #70308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/apiserver
sig/api-machinery
mikedanese
force-pushed
the
trev7
branch
2 times, most recently
from
3918ef3 to
7ad2476
Compare
|
/retest |
|
/assign @yliaog |
liggitt
reviewed
Oct 29, 2018
| @@ -328,11 +329,14 @@ func (s *BuiltInAuthenticationOptions) ToAuthenticationConfig() kubeauthenticato | |||
| } | |||
|
|
|||
| if s.ServiceAccounts != nil { | |||
| if s.ServiceAccounts.Issuer != "" && len(s.APIAudiences) == 0 { | |||
There was a problem hiding this comment.
try to avoid mutating s, modify the returned config instead?
This is a sane default that users can choose to migrate away from later.
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, mikedanese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
george-angel
added a commit
to utilitywarehouse/tf_kube_ignition
that referenced
this pull request
Dec 10, 2020
``` Error: --service-account-signing-key-file, --service-account-issuer, and --api-audiences should be specified together ``` kubernetes/kubernetes#70308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sane default that users can choose to migrate away from later.
Fixes #70104
/kind feature
/sig auth