Refactor scheduler_test.go to use Clientset #70290
Merged
+65
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
tossmilestone
force-pushed
the
scheduler-test-refactor
branch
from
5280211 to
e3e2aa2
Compare
k8s-ci-robot
added
size/M
tossmilestone
force-pushed
the
scheduler-test-refactor
branch
3 times, most recently
from
4a6571a to
65eb6da
Compare
Contributor
Author
|
/assign @misterikkit |
Contributor
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, tossmilestone The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: He Xiaoxi <[email protected]>
tossmilestone
force-pushed
the
scheduler-test-refactor
branch
from
65eb6da to
12634bf
Compare
misterikkit
suggested changes
Oct 29, 2018
misterikkit
left a comment
misterikkit
left a comment
There was a problem hiding this comment.
This looks pretty good. I think overall, scheduler_test.go is already somewhat messy, but this PR is not about cleaning that up. Please look into the SelfLink thing, and then I'll approve.
| "//pkg/scheduler/factory:go_default_library", | ||
| "//pkg/scheduler/internal/cache:go_default_library", | ||
| "//pkg/scheduler/internal/cache/fake:go_default_library", | ||
| "//pkg/scheduler/testing:go_default_library", |
| Name: id, | ||
| UID: types.UID(id), | ||
| SelfLink: schedulertesting.Test.SelfLink(string(v1.ResourcePods), id), | ||
| SelfLink: fmt.Sprintf("/api/v1/%s/%s", string(v1.ResourcePods), id), |
There was a problem hiding this comment.
Do the tests pass with this line removed? My understanding is that SelfLink is not important to any of the behavior we are trying to test.
Contributor
Author
There was a problem hiding this comment.
I have run the test without SelfLink, but it will cause error below:
1030 01:51:38.384380 13145 event.go:259] Could not construct reference to: '&v1.Pod{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"foo", GenerateName:"", Namespace:"", SelfLink:"", UID:"foo", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, Spec:v1.PodSpec{Volumes:[]v1.Volume(nil), InitContainers:[]v1.Container(nil), Containers:[]v1.Container(nil), RestartPolicy:"", TerminationGracePeriodSeconds:(*int64)(nil), ActiveDeadlineSeconds:(*int64)(nil), DNSPolicy:"", NodeSelector:map[string]string(nil), ServiceAccountName:"", DeprecatedServiceAccount:"", AutomountServiceAccountToken:(*bool)(nil), NodeName:"machine1", HostNetwork:false, HostPID:false, HostIPC:false, ShareProcessNamespace:(*bool)(nil), SecurityContext:(*v1.PodSecurityContext)(nil), ImagePullSecrets:[]v1.LocalObjectReference(nil), Hostname:"", Subdomain:"", Affinity:(*v1.Affinity)(nil), SchedulerName:"", Tolerations:[]v1.Toleration(nil), HostAliases:[]v1.HostAlias(nil), PriorityClassName:"", Priority:(*int32)(nil), DNSConfig:(*v1.PodDNSConfig)(nil), ReadinessGates:[]v1.PodReadinessGate(nil), RuntimeClassName:(*string)(nil), EnableServiceLinks:(*bool)(nil)}, Status:v1.PodStatus{Phase:"", Conditions:[]v1.PodCondition(nil), Message:"", Reason:"", NominatedNodeName:"", HostIP:"", PodIP:"", StartTime:(*v1.Time)(nil), InitContainerStatuses:[]v1.ContainerStatus(nil), ContainerStatuses:[]v1.ContainerStatus(nil), QOSClass:""}}' due to: 'selfLink was empty, can't make reference'. Will not report event: 'Normal' 'Scheduled' 'Successfully assigned /foo to machine1'
and the test will hang waiting for the event. So the SelfLink is necessary for test. 😢
There was a problem hiding this comment.
Huh, weird. I'd like to look into that eventually.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Use
k8s.io/client-go/kubernetes/fake.Clientsetas the fake k8s client inpkg/scheduler/scheduler_test.go.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #68962
Special notes for your reviewer:
Does this PR introduce a user-facing change?: