Skip to content

changes done to enable br_netfilter and ip_forward for debian packages #70152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2018
Merged

changes done to enable br_netfilter and ip_forward for debian packages #70152

merged 2 commits into from
Oct 26, 2018

Conversation

ashwanikhemani
Copy link
Contributor

@ashwanikhemani ashwanikhemani commented Oct 24, 2018 •
edited
Loading

What this PR does / why we need it:
For any Debian distribution, this will help in loading the br_netfilter module automatically and enable IP
forwarding.

These are required by kubeadm otherwise it fails fatally if this is not configured. As they're mandatory in kubeadm, they should be configured automatically as part of the installation of kubeadm. This would help in improving kubeadm support for any CRI runtime besides Docker (eg. CRI-O)

Which issue(s) this PR fixes *
Fixes # kubernetes/kubeadm#1146

Added functionality to enable br_netfilter and ip_forward for debian packages to improve kubeadm support for CRI runtime besides Docker.

/kind bug

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2018
@ashwanikhemani
Copy link
Contributor Author

I have signed the Contributor License Agreement.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 24, 2018
@ashwanikhemani
Copy link
Contributor Author

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 24, 2018
@ashwanikhemani
Copy link
Contributor Author

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 24, 2018
@timothysc
Copy link
Member

/ok-to-test
/assign @timothysc @ixdy

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 24, 2018
@timothysc timothysc added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Oct 24, 2018
@timothysc
Copy link
Member

@ashwanikhemani please add a release note.

@ashwanikhemani ashwanikhemani changed the title changes done to enable br_filter and ip_forward for debian packages changes done to enable br_netfilter and ip_forward for debian packages Oct 24, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 24, 2018
@ashwanikhemani
Copy link
Contributor Author

/retest

@timothysc
Copy link
Member

/test pull-kubernetes-verify

@ashwanikhemani ashwanikhemani force-pushed the myfeature branch 2 times, most recently from 187ea28 to 45383ac Compare October 25, 2018 04:59
@ashwanikhemani
Copy link
Contributor Author

/test pull-kubernetes-verify

@ashwanikhemani
Copy link
Contributor Author

ashwanikhemani commented Oct 25, 2018 •
edited
Loading

I ran the verification tasks on my local Debian machine and verify-bazel task completed successfully.
Is there a way to check the logs for this script only?

Update: Now the pull-kubernetes-verify is failing at the start only :
Now it is failing with a new error : W1025 05:11:21.830] Unable to find image 'gcr.io/k8s-testimages/kubekins-test:1.13-v20181003-42c05e7e9' locally

@timothysc
Copy link
Member

/retest

rosti
rosti approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@rosti rosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashwanikhemani thanks for this contribution!

As for the broken test, please run ./hack/update-bazel.sh from the k8s source root directory and update the PR with the changes, that the script makes.

@ixdy
Copy link
Member

ixdy commented Oct 25, 2018

/approve
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwanikhemani, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2018
@ixdy
Copy link
Member

ixdy commented Oct 25, 2018

/assign @rosti

@ixdy
Copy link
Member

ixdy commented Oct 25, 2018

As has been noted elsewhere, this is unfortunately not the canonical source of truth for the release debs; those are in https://github.com/kubernetes/release. These are used for CI, however.

@timothysc
Copy link
Member

As has been noted elsewhere, this is unfortunately not the canonical source of truth for the release debs; those are in https://github.com/kubernetes/release. These are used for CI, however

... for now.

timothysc
timothysc approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2018
@k8s-ci-robot k8s-ci-robot merged commit c23e94a into kubernetes:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc approved these changes

@rosti rosti rosti approved these changes

@luxas luxas Awaiting requested review from luxas

Assignees

@timothysc timothysc

@rosti rosti

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ashwanikhemani @k8s-ci-robot @timothysc @ixdy @rosti