Skip to content

Reduce cardinality of admission webhook metrics #69895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Oct 22, 2018
Merged

Reduce cardinality of admission webhook metrics #69895

k8s-ci-robot merged 1 commit into from
Oct 22, 2018
+17 −32

Conversation

@jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Oct 16, 2018 •
edited
Loading

Per #69540, including resource related labels on admission webhook labels on large cluster with lots of CRDs incurs unacceptable amounts of memory use and churn.

This PR removes the resource related labels: group, version, resource and subresource.

Reduce memory utilization of admission webhook metrics by removing resource related labels.

/sig api-machinery
/kind cleanup
/cc @smarterclayton

@jpbetz jpbetz self-assigned this Oct 16, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 16, 2018
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 16, 2018
@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 16, 2018

/retest

@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 17, 2018

This is ready for review.

@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 22, 2018

@smarterclayton Friendly ping for review

@smarterclayton
Copy link
Contributor

smarterclayton commented Oct 22, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 22, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit 04d3949 into kubernetes:master Oct 22, 2018
@MHBauer MHBauer mentioned this pull request Dec 22, 2018
Closed
This was referenced Feb 26, 2019
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Mar 1, 2019
@k8s-ci-robot
Merge pull request #74622 from jennybuckley/automated-cherry-pick-of-…
fae605d 
…#69895-upstream-release-1.11

Automated cherry pick of #69895: Reduce cardinality of admission webhook metrics
k8s-ci-robot added a commit that referenced this pull request Mar 4, 2019
@k8s-ci-robot
Merge pull request #74621 from jennybuckley/automated-cherry-pick-of-…
f833b52 
…#69895-upstream-release-1.12

Automated cherry pick of #69895: Reduce cardinality of admission webhook metrics
@logicalhan logicalhan mentioned this pull request Apr 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@sttts sttts Awaiting requested review from sttts

Assignees

@jpbetz jpbetz

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpbetz @smarterclayton @k8s-ci-robot