change default azure file mount permission to 0777 #69854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
sig/storage
k8s-ci-robot
added
lgtm
This was referenced Oct 18, 2018
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 18, 2018
…9854-upstream-release-1.12 Automated cherry pick of #69854: change azure file mount permission to 0777
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 19, 2018
…9854-upstream-release-1.11 Automated cherry pick of #69854: change azure file mount permission to 0777
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 19, 2018
…9854-upstream-release-1.10 Automated cherry pick of #69854: change azure file mount permission to 0777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Default azure file permission
0755is not suitable for most users, dozens of users complain about this, set as0777is the best choice here, if users don't want0777, then they could use mountOptions to overridedir_modeandfile_mode.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #69853
Special notes for your reviewer:
I have seen at least 20+ complain about this default permission of
0755, let's set as0777by default in all versions.Release note:
/assign @feiskyer
cc @khenidak
/kind bug