Skip to content

etcd2 code cleanup, remove deserialization cache #69842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Oct 16, 2018
Merged

etcd2 code cleanup, remove deserialization cache #69842

k8s-ci-robot merged 1 commit into from
Oct 16, 2018

Conversation

@liggitt
Copy link
Member

@liggitt liggitt commented Oct 16, 2018 •
edited
Loading

What this PR does / why we need it:
finishes cleaning up remnants of etcd2 storage code. removes unused deserialization cache flags/config.

Viewing the diff without whitespace shows the actual changes more clearly.

Release note:

kube-apiserver: the `--deserialization-cache-size` flag is no longer used, is deprecated, and will be removed in a future release

/sig api-machinery
/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 16, 2018
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/apiserver needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 16, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 16, 2018
@liggitt
Copy link
Member Author

liggitt commented Oct 16, 2018

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 16, 2018
@wojtek-t
Copy link
Member

wojtek-t commented Oct 16, 2018

Thanks a lot for this @liggitt !

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 21cb721 into kubernetes:master Oct 16, 2018
@liggitt liggitt deleted the etcd2-cleanup branch October 16, 2018 14:06
@fedebongio
Copy link
Contributor

fedebongio commented Oct 18, 2018

/cc @wenjiaswe

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 18, 2018

@fedebongio: GitHub didn't allow me to request PR reviews from the following users: wenjiaswe.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @wenjiaswe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ialidzhikov ialidzhikov mentioned this pull request Mar 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjcullen cjcullen Awaiting requested review from cjcullen

@davidopp davidopp Awaiting requested review from davidopp

Assignees

@wojtek-t wojtek-t

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liggitt @wojtek-t @k8s-ci-robot @fedebongio