Use fsync instead of sync for test #69755
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
sig/testing
Contributor
|
/kind cleanup |
k8s-ci-robot
added
kind/cleanup
Contributor
|
/retest |
sync sometimes hangs with misbehaving NFS during the tests Signed-off-by: Mrunal Patel <[email protected]>
k8s-ci-robot
added
the
sig/apps
Contributor
Author
|
/test pull-kubernetes-e2e-gce |
Member
|
@kubernetes/sig-storage-bugs |
k8s-ci-robot
added
sig/storage
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
👍 |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync sometimes hangs with misbehaving NFS during the tests
cc: @derekwaynecarr @smarterclayton @runcom
Signed-off-by: Mrunal Patel [email protected]
What this PR does / why we need it:
This PR switches to using fsync and dd to persist a file for stateful set test instead of touch and sync.
We have seen sync sometimes flake during the tests due to NFS issues.