Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dry-run: Promote from Alpha to Beta #69644

Merged
merged 1 commit into from
Oct 13, 2018
Merged

dry-run: Promote from Alpha to Beta #69644

merged 1 commit into from
Oct 13, 2018

Conversation

apelisse
Copy link
Member

Also remove the test that used to check that the dry-run flag is
forbidden.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Dry-run is promoted to Beta and will be enabled by default.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 10, 2018
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 10, 2018
@apelisse
Copy link
Member Author

/assign @lavalamp

@lavalamp
Copy link
Member

Is this the only change needed?

@apelisse
Copy link
Member Author

We need to update the documentation, but the release branch hasn't been created yet. We don't want to change the default for the webhook configuration before GA, so I do think it is.

@apelisse
Copy link
Member Author

See #68514

@lavalamp
Copy link
Member

/approve
/lgtm

To give @deads2k / @smarterclayton / @liggitt a chance to weigh in:
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2018
liggitt
liggitt reviewed Oct 12, 2018
View reviewed changes
staging/src/k8s.io/apiserver/pkg/endpoints/apiserver_test.go
@@ -3865,55 +3865,6 @@ func (storage *SimpleRESTStorageWithDeleteCollection) DeleteCollection(ctx conte
return nil, nil
}

func TestDryRun(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could keep this to make sure things still respect the feature gate being disabled until it is removed (with a call to defer utilfeaturetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.DryRun, false)())

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agreed, makes sense to me

@liggitt
Copy link
Member

liggitt commented Oct 12, 2018

other than the comment on the test, lgtm

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 12, 2018
dry-run: Promote from Alpha to Beta
5dca8e0 
Also remove the test that used to check that the dry-run flag is
forbidden.
@liggitt
Copy link
Member

liggitt commented Oct 12, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2018
@apelisse
Copy link
Member Author

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 12, 2018
@apelisse
Copy link
Member Author

/retest

@apelisse
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit 46f0f2a into kubernetes:master Oct 13, 2018
@apelisse apelisse mentioned this pull request Oct 15, 2018
Closed
10 tasks
@jennybuckley jennybuckley mentioned this pull request Nov 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@lavalamp lavalamp

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apelisse @lavalamp @k8s-ci-robot @liggitt