Skip to content

fix GetVolumeLimits log flushing issue #69558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Oct 10, 2018
Merged

fix GetVolumeLimits log flushing issue #69558

k8s-ci-robot merged 1 commit into from
Oct 10, 2018

Conversation

@andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Oct 9, 2018 •
edited
Loading

What this PR does / why we need it:
This PR is to fix the flushing log issue on k8s cluster.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #69503

Special notes for your reviewer:
In v1.12, GetVolumeLimits is enabled by default, take aws ebs for example, it will return error directly if it could not get cloud provider:

kubernetes/pkg/volume/awsebs/aws_ebs.go

Line 111 in f9acfd8

return nil, fmt.Errorf("No cloudprovider present")

And logging as V(4):

kubernetes/pkg/kubelet/nodestatus/setters.go

Line 775 in f9acfd8

glog.V(4).Infof("Error getting volume limit for plugin %s", volumePlugin.GetPluginName())

I suppose V(4) logs won't display in logs. Let me make the same change.

Release note:

fix GetVolumeLimits log flushing issue

/assign @gnufied
cc @turchanov

@andyzhangx
fix GetVolumeLimits log flushing issue
e67b369 
fix logging flushing issue in GetVolumeLimits
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 9, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 9, 2018
@andyzhangx
Copy link
Member Author

andyzhangx commented Oct 9, 2018

/sig azure
/kind bug

@k8s-ci-robot k8s-ci-robot added sig/azure kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 9, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2018
@andyzhangx andyzhangx mentioned this pull request Oct 9, 2018
Closed
@gnufied
Copy link
Member

gnufied commented Oct 9, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@fejta-bot
Copy link

fejta-bot commented Oct 9, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

fejta-bot commented Oct 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@andyzhangx
Copy link
Member Author

andyzhangx commented Oct 10, 2018

/test pull-kubernetes-integration

@fejta-bot
Copy link

fejta-bot commented Oct 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@andyzhangx
Copy link
Member Author

andyzhangx commented Oct 10, 2018

/test pull-kubernetes-integration
/test pull-kubernetes-e2e-kops-aws

@fejta-bot
Copy link

fejta-bot commented Oct 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

fejta-bot commented Oct 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 3ac3889 into kubernetes:master Oct 10, 2018
@andyzhangx andyzhangx mentioned this pull request Oct 11, 2018
Merged
k8s-ci-robot added a commit that referenced this pull request Oct 14, 2018
@k8s-ci-robot
Merge pull request #69649 from andyzhangx/automated-cherry-pick-of-#6…
ac46c17 
…9558-upstream-release-1.12

Automated cherry pick of #69558: fix GetVolumeLimits log flushing issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karataliu karataliu Awaiting requested review from karataliu

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@gnufied gnufied

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error message: "failed to get azure cloud in GetVolumeLimits" in bare-metal setup after upgrade to 1.12.1

4 participants

@andyzhangx @k8s-ci-robot @gnufied @fejta-bot