Skip to content

[aws] allow true/false in lb annotations #69436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2018
Merged

[aws] allow true/false in lb annotations #69436

merged 1 commit into from
Oct 5, 2018

Conversation

mcrute
Copy link
Contributor

@mcrute mcrute commented Oct 4, 2018 •
edited
Loading

What this PR does / why we need it:
Updates internal load balancer annotation to allow true/false instead of just empty string.

Which issue(s) this PR fixes:
Fixes #69237

Special notes for your reviewer:

Release note:

service.beta.kubernetes.io/aws-load-balancer-internal now supports true and false values, previously it only supported non-empty strings

/sig aws
/cc @d-nishi @jsafrane
/kind bug

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 4, 2018
@k8s-ci-robot k8s-ci-robot requested a review from d-nishi October 4, 2018 19:24
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/aws kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 4, 2018
@mcrute
Copy link
Contributor Author

mcrute commented Oct 4, 2018

/cc @jsafrane @justinsb @gnufied

@jsafrane
Copy link
Member

jsafrane commented Oct 5, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 5, 2018
@jsafrane
Copy link
Member

jsafrane commented Oct 5, 2018

/lgtm

Reading API deprecation rules, beta annotation is an API field protected under it, but I consider it as a bugfix, not API change. Nobody with service.beta.kubernetes.io/aws-load-balancer-internal: "false" would expect that it means "true".

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, mcrute

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2018
@k8s-ci-robot k8s-ci-robot merged commit 5fdb0c7 into kubernetes:master Oct 5, 2018
@mcrute mcrute mentioned this pull request Oct 16, 2018
Closed
6 tasks
@mcrute mcrute deleted the issue-69237 branch December 3, 2018 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-nishi d-nishi Awaiting requested review from d-nishi

@gnufied gnufied Awaiting requested review from gnufied

@jsafrane jsafrane Awaiting requested review from jsafrane

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal ELB true|false doesn't work
3 participants
@mcrute @jsafrane @k8s-ci-robot